Interaction between Search by types and Construct #1830
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvw
force-pushed
the
replace-by-type-search
branch
from
d669f70
to
9c8d853
Compare
Core search engine by type, strongly inspired by https://doc.sherlocode.com/. The library is globally dependency agnostic so that it can potentially be used one day as a base for other applications.
Currently, Merlin's code base only uses test CRAMs, although some functions are easier to maintain if they are unit-tested. It is therefore a ‘gradual’ introduction of unit tests into the code base.
And add the support of dynamic switching between search by types and search by polarity
xvw
force-pushed
the
replace-by-type-search
branch
from
9c8d853
to
0997604
Compare
|
(After a small chat with @voodoos, the UI seems a little bit controversial so I close it and improve the previous one!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch (on top of #1828) introduce an interactive way to search directly from a buffer.
constructiblewhich is a string that represent the function filled with holes (so it can be used in every other client)merlin-searchthat ask for a query if nothing is selected but can use the region as a query and replace the region with the function and holes. Demonstration below