CI: Use tytan652/flatpak-github-actions image for Flatpak jobs #10074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tytan652
added
Bug Fix
tytan652
force-pushed
the
new_fp_image
branch
2 times, most recently
from
d5ed78a
to
4fed8aa
Compare
tytan652
force-pushed
the
new_fp_image
branch
3 times, most recently
from
ed6bf19
to
172d8bf
Compare
The actual Fedora-based image are not compatible with the action because Fedora provides unstable version of flatpak-builder and a breakage happened between two unstable version This also means that the action is not completely compatible with flatpak-builder 1.4 To solve this issue an alternative base image was proposed, but it is not upstreamed yet, so my fork registry is used for now Also flatpak-builder-lint is provided in the image so the related action is modified to work with the provided version
tytan652
force-pushed
the
new_fp_image
branch
from
172d8bf
to
6fc80b8
Compare
|
I just regret that no feedback were given in the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The actual Fedora-based image are not compatible with the action because Fedora provides unstable version of flatpak-builder and a breakage happened between two unstable version
This also means that the action is not completely compatible with flatpak-builder 1.4
To solve this issue an alternative base image was proposed, but it is not upstreamed yet, so my fork registry is used for now
Also flatpak-builder-lint is provided in the image so the related action is modified to work with the provided version
Motivation and Context
Upstream action PR: Add a Freedesktop SDK based image flatpak/flatpak-github-actions#173
Provide a more long-term solution than CI: Downgrade flatpak-builder to fix Flatpak publish #9984 which is only in the release branch even if I have to maintain those images myself for a while.
How Has This Been Tested?
Flatpak CIs
Types of changes
Checklist: