Uncouple bridge generation from mappings refresh. #3439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We change the "refresh-external-resources" target so that it still refreshes (1) the imports, (2) the "local" imports (in fact the local copies of the foreign ontologies used to build Composite Metazoan), (3) the externally maintained mapping sets, (4) the externally maintained bridges; BUT it does not re-generate the bridge files that are dependent on the refreshed mappings. The mappings-derived bridges are now expected to be built at release time (and also at QC time). We build them under MIR=false, so they will only be built using the locally available mappings (from the last time they were refreshed), without triggering the download of any remote resource. Editors/maintainers can still locally trigger the building of the bridge files at any time by explicitly invoking the "refresh-bridges" target, if they want/need to do so. This does not change anything for whoever is running the refresh pipeline nowadays: it's still only a matter of invoking "refresh-external-resources". The only difference is that this won't trigger a rebuild of the bridge files. Two benefits: the "refresh imports" PRs will no longer be polluted by needless changes in the bridge files, in which only the version IRI has changed; the bridge files will always be generated (at least) at the same time as the release, so they will always have a correct version IRI. Minor cosmetic changes also in this commit: * "CUSTOM_BRIDGES" is renamed to "EXTERN_BRIDGES", which reflects better the true nature of those bridges (it does not really matter that they are "custom", what matters is that they are not generated here). * We use MIR=false, rather than IMP=false, to prevent the downloading of any remote resource. This is for consistency with other parts of the Makefile. closes #3438
gouttegd
force-pushed
the
uncouple-mappings-refresh-and-bridge-generation
branch
from
70efd7c to
9b64085
Compare
matentzn
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We change the
refresh-external-resourcestarget so that it still refreshes (1) the imports, (2) the "local" imports (in fact the local copies of the foreign ontologies used to build Composite Metazoan), (3) the externally maintained mapping sets, (4) the externally maintained bridges; but it does not re-generate the bridge files that are dependent on the refreshed mappings.The mappings-derived bridges are now expected to be built at release time (and also at QC time). We build them under
MIR=false, so they will only be built using the locally available mappings (from the last time they were refreshed), without triggering the download of any remote resource.Editors/maintainers can still locally trigger the building of the bridge files at any time by explicitly invoking the
refresh-bridgestarget, if they want/need to do so.This does not change anything for whoever is running the refresh pipeline nowadays: it’s still only a matter of invoking
refresh-external-resources. The only difference is that this won't trigger a rebuild of the bridge files.Two benefits: the “refresh imports” PRs will no longer be polluted by needless changes in the bridge files, in which only the version IRI has changed; the bridge files will always be generated (at least) at the same time as the release, so they will always have a correct version IRI.
Minor cosmetic changes also in this commit:
CUSTOM_BRIDGESis renamed toEXTERN_BRIDGES, which reflects better the true nature of those bridges (it does not really matter that they are “custom”, what matters is that they are not generated here).We use
MIR=false, rather thanIMP=false, to prevent the downloading of any remote resource. This is for consistency with other parts of the Makefile.closes #3438