Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options: Report image format and virtual size #6

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Aug 5, 2022

  1. images_test: import units

    Import and use units constants in the test to improve
    readability.
    
    Signed-off-by: Albert Esteve <[email protected]>
    aesteve-rh committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    42ba935 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2022

  1. images.md: fix extents typo

    Fix small typo on extents example.
    
    Signed-off-by: Albert Esteve <[email protected]>
    aesteve-rh committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    51cd6d1 View commit details
    Browse the repository at this point in the history
  2. options: Report image format and virtual size

    Report image virtual size in OPTIONS so clients can get the image size
    without a possibly slow extent call.
    
    Report the format since OPTIONS can report the virtual size only when
    the backend provides raw format. This is used when using the http
    backend to report OPTIONS to the client.
    
    Reporting virtual size is easy with the nbd and memory backends since
    they always use raw format.
    
    When using file backend and qcow2 image, we don't have access to the
    image virtual size, and this size is not helpful to the user uploading
    or downloading data. Currently we don't know about the image format
    since engine does not report it in the ticket.
    
    The http backend reports the info from the remote server, so it depends
    on the backend used by the remote server, and on having new server
    reporting the format and size.
    
    To keep code and the API simple, we report virtual size only when using
    the nbd and memory backends. When engine will report the image format
    for the file backend, we can also report the size for raw images access
    via the file backend.
    
    Change-Id: I89118301c98dc2d11c25a4d1e7ef83df26336f01
    Related: oVirt#67
    Bug-Url: https://bugzilla.redhat.com/1924945
    Signed-off-by: Nir Soffer <[email protected]>
    nirs authored and aesteve-rh committed Aug 8, 2022
    Configuration menu
    Copy the full SHA
    32e6573 View commit details
    Browse the repository at this point in the history