Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiler: fixed order of parameters in nss script for PushPerfScope() #1799

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Profiler: fixed order of parameters in nss script for PushPerfScope() #1799

wants to merge 1 commit into from
+4 −3

Conversation

julien-lecomte
Copy link
Contributor

Without this patch, the result of NWNX_Profiler_PushPerfScope("PerfScopeName", "tag0_tag", "tag0_value"); is NWNX_Profiler.TimingEvent,EventName=tag0_tag,tag0_value=PerfScopeName

The patch fixes the order of the pushed arguments:

NWNX_Profiler_PushPerfScope("Test2", "tag0_tag", "tag0_value");
NWNX_Profiler_PushPerfScope("Test3", "tag0_tag", "tag0_value");

# Gives:
NWNX_Profiler.TimingEvent,EventName=Test2,tag0_tag=tag0_value
NWNX_Profiler.TimingEvent,EventName=Test3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@julien-lecomte