Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2113T-T10-1] SplitLah #8

Open
wants to merge 2,719 commits into
base: master
Choose a base branch
from
Open
Changes from 141 commits
Commits
Show all changes
2719 commits
Select commit Hold shift + click to select a range
4dd8583
Add test section for session delete command
froststein Apr 10, 2022
d6b0d74
Add test section for session edit command
froststein Apr 10, 2022
76a2b5b
Merge pull request #484 from warrencxw/branch-cleanup
froststein Apr 10, 2022
2756285
Update to sort in alphabetical order
Apr 10, 2022
d8526ab
Update test cases to follow overall standardisation
Apr 10, 2022
6ec2dcc
Update expected.txt to include dollar sign
Apr 10, 2022
bd7bd24
Amend grammar
froststein Apr 10, 2022
8b47b89
Add for test cases for session edit command in DG
froststein Apr 10, 2022
59dc1b1
Add test section for group create command
froststein Apr 10, 2022
62773c1
Add test section for group delete command
froststein Apr 10, 2022
affd680
Add test section for group edit command
froststein Apr 10, 2022
00b8983
Add test section for storage
froststein Apr 10, 2022
7e61090
Add trailing white spaces
Apr 10, 2022
81c4b1f
Amend sentence structure
froststein Apr 10, 2022
892a06f
Amend more sentence structures
froststein Apr 10, 2022
fb94991
Amend spelling mistake
froststein Apr 10, 2022
ee611b1
Amend phrasing
froststein Apr 10, 2022
892486a
Merge branch 'master' into docs-developerguide
warrencxw Apr 10, 2022
07a9f31
Merge pull request #487 from froststein/docs-developerguide
ivanaitzliddat Apr 10, 2022
3186f5d
Merge pull request #486 from ivanaitzliddat/branch-activity
froststein Apr 10, 2022
bd56f3a
Update user stories to remove capitalisation of user
Apr 10, 2022
c4e457b
Merge branch 'master' into branch-developerGuide
Apr 10, 2022
9eb3ee2
Update test cases to follow overall standardisation
Apr 10, 2022
fe652ae
Fix error in test scenario 3 of session create
Apr 10, 2022
d3c8974
Move isSamePersonList method to PersonList object class
lelerer Apr 10, 2022
3c7c517
fix group edit bug
lelerer Apr 10, 2022
7a08496
Remove error message
lelerer Apr 10, 2022
48a63eb
Fix checkstyle error
lelerer Apr 10, 2022
b746f99
Change the phrasing of error message
lelerer Apr 10, 2022
5a3ff19
Align messages and fix checkstyle error
lelerer Apr 10, 2022
1ea8cdd
Change error message name
lelerer Apr 10, 2022
f7ab968
Add ActitivityViewCommand and ActitivityListCommand sequence diagram
lelerer Apr 10, 2022
ea50082
Add group /edit command DG explanation
lelerer Apr 10, 2022
3f5b9ca
Remove some lines
lelerer Apr 11, 2022
eb13fe3
Update PPP
lunespell Apr 11, 2022
46de465
Update ppp
lunespell Apr 11, 2022
5a1a6ea
Update PPP
lunespell Apr 11, 2022
f23bff9
Update ppp
lunespell Apr 11, 2022
904f0b2
Delete the use of a variable
lelerer Apr 11, 2022
2d50374
Change the order of check
lelerer Apr 11, 2022
dcc7842
Fix some bugs
lelerer Apr 11, 2022
de9de9e
Add Person tests, remove unused code from Person
lunespell Apr 11, 2022
24923d3
Fix test assert statement
lunespell Apr 11, 2022
d27ee86
Update ppp
lunespell Apr 11, 2022
f4569a7
Fix bug
lelerer Apr 11, 2022
8da7b0a
Abstract out methods for SLAP
lunespell Apr 11, 2022
c8de0dc
Merge pull request #478 from lelerer/fixGroupEdit
ivanaitzliddat Apr 11, 2022
de07e2e
Update diagram
lelerer Apr 11, 2022
9a161e9
Update DG
lelerer Apr 11, 2022
65b2f21
Merge remote-tracking branch 'origin/master' into DG
lelerer Apr 11, 2022
2c87c92
Add Test case for activity view in DG
froststein Apr 11, 2022
43aed5c
Update to follow overall standardisation
Apr 11, 2022
30ab796
Add UG GroupEdit explanation
lelerer Apr 11, 2022
ae51d5e
Add in explanation
lelerer Apr 11, 2022
f1feb55
Merge pull request #490 from froststein/docs-developerguide
ivanaitzliddat Apr 11, 2022
b3fb330
Update session list command sequence diagram
Apr 11, 2022
2465962
Add activity list and activity view sequence diagrams
Apr 11, 2022
e17e0cb
Replace prepare function with command parser in Message class
warrencxw Apr 11, 2022
76f2c18
Print message if no details are changed
lunespell Apr 11, 2022
cb2c344
Remove unused variable in Activity Class
froststein Apr 11, 2022
971b1b4
Remove unused methods in ActivityCost Class
froststein Apr 11, 2022
6c759aa
Remove unused methods in Person Class
froststein Apr 11, 2022
c3babcc
Remove unused methods in PersonList Class
froststein Apr 11, 2022
e92cd2c
Remove unused methods in TableFormatter Class
froststein Apr 11, 2022
32c0b3c
Remove unused methods in TextUI Class
froststein Apr 11, 2022
837de3e
Update PPP
lelerer Apr 11, 2022
6cc0459
Remove unused methods in PersonCostPair Class
froststein Apr 11, 2022
951f06b
Add documentation
lunespell Apr 11, 2022
6c07949
Update SessionEditCommand implementation
froststein Apr 11, 2022
cde98ab
Fix checkstyle errors
lunespell Apr 11, 2022
7fe42d2
Merge pull request #488 from matheril/ppp
warrencxw Apr 11, 2022
68ff05f
Update developer guide for ActivityEditCommand
lunespell Apr 11, 2022
400e9f1
Add workflow for activity view command
Apr 11, 2022
8ac367b
Update ActivityViewCommand DG
lelerer Apr 11, 2022
f901f3e
Merge branch 'master' into branch-developerGuide
Apr 11, 2022
5da7f99
Rename a diagram file
lelerer Apr 11, 2022
c3e18c6
Update GroupEditCommand sequence diagram
lelerer Apr 11, 2022
a193bf6
Add JUnit tests
lunespell Apr 11, 2022
3041822
Update sequence diagram
lunespell Apr 11, 2022
6f6537f
Update format of if else statements
Apr 11, 2022
1f5760e
Merge pull request #491 from lelerer/DG
ivanaitzliddat Apr 11, 2022
ddfa95e
Merge branch 'master' into branch-developerGuide
Apr 11, 2022
7b41b72
Merge pull request #489 from matheril/PersonTest
warrencxw Apr 11, 2022
9e31516
Update screenshots in UG
froststein Apr 11, 2022
377d9d3
Amend UG explanation
froststein Apr 11, 2022
a59d11d
Add test cases for activity list
Apr 11, 2022
7d4eadb
Update Activity command section in UG
froststein Apr 11, 2022
56f4521
Update test cases for activity create
Apr 11, 2022
2790d74
Replace mentioning of function with method in PersonList class
warrencxw Apr 11, 2022
339e7b7
Replace mentioning of function with method in JUnit test for Profile
warrencxw Apr 11, 2022
f84e8f5
Update group command for UG
froststein Apr 11, 2022
d289ef5
Add test cases for activity edit
Apr 11, 2022
b8f1924
Merge pull request #493 from froststein/branch-bugfix-and-testing
warrencxw Apr 11, 2022
1207174
Update the line between each section
Apr 11, 2022
5fb2cf5
Update PPP to include text-based testing
warrencxw Apr 11, 2022
3c897a0
Remove redundant lines between each section
Apr 11, 2022
159db1a
Merge pull request #495 from warrencxw/branch-cleanup
froststein Apr 11, 2022
a9104d2
Update .gitignore
lunespell Apr 11, 2022
f738ba7
Update explanation in sections for PPP
froststein Apr 11, 2022
b088bdc
Change sequence diagram for ActivityEditCommand
lunespell Apr 11, 2022
b8332b6
Fix typo in DG and remove unused import
lunespell Apr 11, 2022
6789a79
Merge pull request #496 from froststein/about-us
ivanaitzliddat Apr 11, 2022
0ab728e
Add index.css for UG
froststein Apr 11, 2022
ce4b20c
Update UG to include back button
froststein Apr 11, 2022
8d68765
Update workflow for group edit command
Apr 11, 2022
0043477
Update link to ref group update diagram
Apr 11, 2022
a02dd12
Fix css class for UG
froststein Apr 11, 2022
21922d6
Update capitalisation of splitlah
Apr 11, 2022
4dc996a
Update UG style
froststein Apr 11, 2022
42c59f4
Update style.css for UG
froststein Apr 11, 2022
39967b3
Add back button for session management section
froststein Apr 11, 2022
9bf20ff
Update session management style
froststein Apr 11, 2022
6fe0130
Add back button for activity and group management in UG
froststein Apr 11, 2022
42f4bd2
Amend style.css
froststein Apr 11, 2022
83d41c8
Update hr tag styling
froststein Apr 11, 2022
57dcdf3
Add test style for codeblock
froststein Apr 11, 2022
363f5ce
Update codeblock style
froststein Apr 11, 2022
25d4e18
Update codeblock style
froststein Apr 11, 2022
30287f2
Shift button placement
froststein Apr 11, 2022
df459b4
Remove overview for transaction management
froststein Apr 11, 2022
f66f566
Add bolding to keywords
froststein Apr 11, 2022
9090645
Add linebreak
froststein Apr 11, 2022
e6a5ca3
Merge pull request #497 from froststein/docs-userguide
warrencxw Apr 11, 2022
ae87fad
Update group edit command to improve presentation
Apr 11, 2022
834e4ed
Merge branch 'master' into branch-ppp
Apr 11, 2022
def344e
Update PPP
lelerer Apr 11, 2022
6671139
Update formatting for PPP under new features
warrencxw Apr 11, 2022
fe66ae2
Update formatting of PPP under enhancements
warrencxw Apr 11, 2022
088eb61
Add hyperlink references under miscellaneous contributions
warrencxw Apr 11, 2022
10cc77b
Add PE dry run bug hunt as part of contributions
warrencxw Apr 11, 2022
6521af5
Add pull request review as part of miscellaneous contributions
warrencxw Apr 11, 2022
8aaae87
Add additional information regarding features
Apr 11, 2022
8f2f81f
Update activity view sequence diagram to align cross
Apr 11, 2022
6695294
Update PPP to include new contributions
froststein Apr 11, 2022
f845481
Merge pull request #485 from ivanaitzliddat/branch-developerGuide
froststein Apr 11, 2022
d3fbfaa
Add section for Instructions for Manual Testing under DG
warrencxw Apr 11, 2022
5f89253
Merge pull request #499 from froststein/about-us
warrencxw Apr 11, 2022
cda66d8
Add buttons for back navigation for DG
froststein Apr 11, 2022
a92c663
Add more description to PersonCostPair
warrencxw Apr 11, 2022
80d60b8
Merge pull request #498 from ivanaitzliddat/branch-ppp
warrencxw Apr 11, 2022
48c1889
Merge pull request #500 from warrencxw/about-us-Warren
froststein Apr 11, 2022
967f2ce
Update ppp
lunespell Apr 11, 2022
cc6007e
Fix sequence diagram
lunespell Apr 11, 2022
18c3303
Merge remote-tracking branch 'origin/master' into PPP
lelerer Apr 11, 2022
9a9558d
Merge branch 'master' into ActivityEditNoChanges
lunespell Apr 11, 2022
0c234f7
Merge branch 'master' into ppp
lunespell Apr 11, 2022
0343d44
Update PPP under new style
lelerer Apr 11, 2022
1fdae2d
Add hr tag and back buttons for DG
froststein Apr 11, 2022
948eead
Update the location of warnings in TOC
warrencxw Apr 11, 2022
8e6032a
Update splitlah.jar to SplitLah.jar
warrencxw Apr 11, 2022
4054374
Update naming conventions
froststein Apr 11, 2022
e85b1b7
Align table of contents under Activity Management
warrencxw Apr 11, 2022
cd5a99c
Remove unnecessary hr tag
warrencxw Apr 11, 2022
74e86a0
Add back to contents button after FAQ
warrencxw Apr 11, 2022
3e22f1c
Update how to use this user guide
warrencxw Apr 11, 2022
b8c7f94
Add more buttons for navigations in DG
froststein Apr 11, 2022
bfd4e42
Update PPP
lunespell Apr 11, 2022
a407074
Capitalise first character
lelerer Apr 11, 2022
34b1a50
Add newline to .gitignore
lunespell Apr 11, 2022
78d8356
Merge branch 'ActivityEditNoChanges' of github.com:matheril/tp into A…
lunespell Apr 11, 2022
4ef6799
Add whitespace right of warning symbol
warrencxw Apr 11, 2022
c3ca106
Remove newline from .gitignore
lunespell Apr 11, 2022
8dccd6b
Edit sentence structure in DG
lelerer Apr 11, 2022
6c26460
Merge pull request #494 from lelerer/PPP
froststein Apr 11, 2022
0b5b8be
Update description of a session
warrencxw Apr 11, 2022
6caa652
Merge pull request #492 from matheril/ActivityEditNoChanges
warrencxw Apr 11, 2022
6cbaa94
Merge branch 'master' into about-us
froststein Apr 11, 2022
9f6de93
Update PPP
froststein Apr 11, 2022
3b3978a
Update button navigation
froststein Apr 11, 2022
b52e5fa
Update PPP with new information
froststein Apr 11, 2022
70a8e48
Update ppp
lunespell Apr 11, 2022
451491d
Update navigation button for storage testing
froststein Apr 11, 2022
b47ac38
Update point indentation for github to detect
warrencxw Apr 11, 2022
ce53aca
Update back navigation for launch testing
froststein Apr 11, 2022
7a5d88b
Update PPP
lunespell Apr 11, 2022
50fd4df
Standardise warning segments
warrencxw Apr 11, 2022
ff486d2
Clean up buttons and headers
froststein Apr 11, 2022
08767a4
Standardise italicisation of arguments in user guide
warrencxw Apr 11, 2022
4dabb1a
Update PPP
lunespell Apr 11, 2022
bcca338
Update phrasing for GST and Service charge
warrencxw Apr 11, 2022
e3e091a
Update glossary table
froststein Apr 11, 2022
7d5527b
Bold all code blocks
warrencxw Apr 11, 2022
567616e
Italicise all cost values in examples
warrencxw Apr 11, 2022
8d4a7ef
Amend DG tables
froststein Apr 11, 2022
db7bb2b
Merge pull request #504 from matheril/ppp
froststein Apr 11, 2022
c9aaa20
Add glossary table
froststein Apr 11, 2022
187a122
Update glossary table
froststein Apr 11, 2022
2801e9a
Update glossary
froststein Apr 11, 2022
ab7b741
Remove extra lines for glossary
froststein Apr 11, 2022
da06beb
Standardise all edit commands
warrencxw Apr 11, 2022
acc21db
Rephrase sentence structure for DG
froststein Apr 11, 2022
74ac34b
Remove codeblocks in glossary
froststein Apr 11, 2022
3acc61b
Update glossary table
froststein Apr 11, 2022
f7b5a4a
Update ActivityTesting section
lunespell Apr 11, 2022
e2e7e36
Standardize "unique identifier" phrase
lunespell Apr 11, 2022
27a2045
Rephrase example in activity edit
warrencxw Apr 11, 2022
2669cb7
Add explanation for back to ToC buttons in how to use user guide
warrencxw Apr 11, 2022
1886fb3
Update phrasing in user guide
warrencxw Apr 11, 2022
8909639
Update link for list of sessionin list of groups
froststein Apr 11, 2022
67e974b
Update ref link
froststein Apr 11, 2022
ad623c6
Merge branch 'docs-developerguide' of https://github.com/froststein/t…
froststein Apr 11, 2022
a169618
Update group create description
warrencxw Apr 11, 2022
07b522a
Remove extra line in DG
froststein Apr 11, 2022
b3b0140
Update group create section
warrencxw Apr 11, 2022
149cac5
Merge pull request #502 from froststein/docs-developerguide
warrencxw Apr 11, 2022
f4bf5dc
Merge branch 'master' into about-us
froststein Apr 11, 2022
068eda1
Fix sequence diagrams
lunespell Apr 11, 2022
582e152
Remove unused sequence diagram
lunespell Apr 11, 2022
6216a1b
Add the word existing to several items in user guide
warrencxw Apr 11, 2022
5de6935
Merge branch 'master' into DG
lunespell Apr 11, 2022
7a0b3d8
Update command format for Activity Edit
warrencxw Apr 11, 2022
b651831
Merge pull request #503 from froststein/about-us
warrencxw Apr 11, 2022
9193722
Merge pull request #506 from matheril/SequenceDiagram
froststein Apr 11, 2022
adea654
Fix GroupEditCommand diagram
lunespell Apr 11, 2022
fa35471
Merge branch 'DG' of github.com:matheril/tp into DG
lunespell Apr 11, 2022
065711d
Fix sequence diagrams
lunespell Apr 11, 2022
fc7c407
Fix sequence diagram
lunespell Apr 11, 2022
4fb7162
Fix table of contents capitalisation
lunespell Apr 11, 2022
dfa7ded
Removed merge conflict diagrams
lunespell Apr 11, 2022
0dab1f1
Add sequence diagrams
lunespell Apr 11, 2022
990fbee
Merge branch 'master' into DG
lunespell Apr 11, 2022
18a4e7d
Merge pull request #505 from matheril/DG
froststein Apr 11, 2022
f734a70
Merge pull request #501 from warrencxw/branch-cleanup
froststein Apr 11, 2022
437545f
Merge branch 'master' into branch-ppp
Apr 11, 2022
41a3261
Remove <hr>
lelerer Apr 11, 2022
05cd543
Update ppp to fit page limit
Apr 11, 2022
fc892ee
Remove unnecessary section
lelerer Apr 11, 2022
da23b70
Update PPP to exclude additional sections
froststein Apr 11, 2022
cbd95ee
Add title
Apr 11, 2022
369571f
Minimise PPP
warrencxw Apr 11, 2022
08e8faf
Clean up PPP
froststein Apr 11, 2022
548012f
Clean up PPP
froststein Apr 11, 2022
faf7a3c
Update ppp
lunespell Apr 11, 2022
c6dcafe
Update ppp
lunespell Apr 11, 2022
780a877
Further minimisation of PPP
warrencxw Apr 11, 2022
5a87788
Merge pull request #507 from ivanaitzliddat/branch-ppp
froststein Apr 11, 2022
7c46a09
Merge pull request #508 from lelerer/PPP
froststein Apr 11, 2022
d8a993f
Merge pull request #509 from froststein/about-us
ivanaitzliddat Apr 11, 2022
eea6489
Merge pull request #510 from matheril/ppp
ivanaitzliddat Apr 11, 2022
3375ffb
Update indentation of header
Apr 11, 2022
eafd52e
Fix typo
lunespell Apr 11, 2022
2d6842d
Merge branch 'master' into branch-ppp
Apr 11, 2022
d7de16b
Merge pull request #511 from warrencxw/about-us-Warren
ivanaitzliddat Apr 11, 2022
f847f60
Merge pull request #513 from matheril/ppp
ivanaitzliddat Apr 11, 2022
d74414a
Merge pull request #512 from ivanaitzliddat/branch-ppp
lunespell Apr 11, 2022
871d25c
Remove one line
lunespell Apr 11, 2022
008a782
Remove name
lunespell Apr 11, 2022
db09f09
Fix ppp
lunespell Apr 11, 2022
7427228
Fix ppp
lunespell Apr 11, 2022
ef369f8
Merge pull request #514 from matheril/ppp
warrencxw Apr 11, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -15,6 +15,8 @@ bin/

/text-ui-test/ACTUAL.txt
/text-ui-test/ACTUAL.TXT
/text-ui-test/EXPECTED-UNIX.TXT
/text-ui-test/EXPECTED-UNIX.txt

# Storage files
/data/
969 changes: 726 additions & 243 deletions docs/DeveloperGuide.md

Large diffs are not rendered by default.

216 changes: 111 additions & 105 deletions docs/UserGuide.md

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions docs/assets/css/style.scss
Original file line number Diff line number Diff line change
@@ -7,6 +7,10 @@
border-left: 0.4rem solid #dce6f0;
}

.main-content code {
font-weight: bold;
}

div.button-box {
text-align: center;
width: 100%;
Binary file modified docs/images/developerguide/ActivityEditCommand.drawio.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/images/developerguide/ActivityViewCommand.drawio.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file not shown.
Binary file not shown.
Binary file modified docs/images/developerguide/GroupEditCommand.drawio.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/images/developerguide/SessionListCommand.drawio.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/images/developerguide/SessionSummaryCommand.drawio.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified docs/images/developerguide/SessionViewCommand.drawio.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 11 additions & 0 deletions docs/team/froststein.md
Original file line number Diff line number Diff line change
@@ -40,11 +40,18 @@ Code Contribution: [RepoSense Link](https://nus-cs2113-ay2122s2.github.io/tp-das
We used the `Serializable` class in `java` to help us simplify file storage.

#### Enhancements to existing features:
* Separated dependency of parser class from command class by creating Command Parser classes for certain features.
* These include [SessionCreateCommandParser](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/parser/commandparser/SessionCreateCommandParser.java),
[SessionDeleteCommandParser](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/parser/commandparser/SessionDeleteCommandParser.java),
[SessionEditCommandParser](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/parser/commandparser/SessionEditCommandParser.java) and
[SessionListCommandParser](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/parser/commandparser/SessionListCommandParser.java) classes.
* [PersonList](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/data/PersonList.java)
* Implemented a wrapper class for storing a list of Person objects.
* Integration of [`TableFormatter`](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/ui/TableFormatter.java) class to
[`Profile`](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/data/Profile.java) class
* Improves the readability when printing list of sessions.
* Added custom 'Back' buttons for User Guide and Developer guide to aid with navigation and readability.


#### Testing
* Added command `Junit` test for
@@ -77,6 +84,10 @@ Documentation Contribution: [RepoSense Link](https://nus-cs2113-ay2122s2.github.
[`Remove a session`](https://ay2122s2-cs2113t-t10-1.github.io/tp/DeveloperGuide.html#remove-a-session) and
[`Edit a session`](https://ay2122s2-cs2113t-t10-1.github.io/tp/DeveloperGuide.html#edit-a-session) sections of the Developer Guide.
* Added user stories section.
* Added Manual Testing Section
* Session: `Creating a session`, `Deleting a Session` and `Editing a Session`.
* Group: `Creating a group`, `Deleting a group`, `Editing a group` and `Viewing a group`.
* Storage

#### Project Management
* Setup Organization & Team Repository.
49 changes: 42 additions & 7 deletions docs/team/lelerer.md
Original file line number Diff line number Diff line change
@@ -15,17 +15,52 @@ the activities they participated in, for a particular session.
Code Contribution: [RepoSense Link](https://nus-cs2113-ay2122s2.github.io/tp-dashboard/?search=&sort=totalCommits%20dsc&sortWithin=title&since=2022-02-18&timeframe=commit&mergegroup=&groupSelect=groupByRepos&breakdown=true&checkedFileTypes=docs~functional-code~test-code~other&tabOpen=true&tabType=authorship&tabAuthor=lelerer&tabRepo=AY2122S2-CS2113T-T10-1%2Ftp%5Bmaster%5D&authorshipIsMergeGroup=false&authorshipFileTypes=docs~functional-code~test-code&authorshipIsBinaryFileTypeChecked=false)

#### New Features
* [Group Create](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/command/GroupCreateCommand.java)
* What it does: Allows users to create groups in the application.
* Justification: This feature allows users to record the details of a group.
* [Group Delete](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/command/GroupDeleteCommand.java)
* What it does: Allows users to delete groups in the application.
* Justification: This feature allows users to remove unnecessary groups that were previously created.
* [Group Edit](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/command/GroupEditCommand.java)
* What it does: Allows users to edit previously created groups.
* Justification: This features allows users to amend mistakes previously made when creating a group.
* Highlights: This was challenging as the edits made had to be crossed check with existing groups within the application.
* [Activity List](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/command/ActivityListCommand.java)
* What it does: Allows users to view all previously created activities within a session.
* Justification: This features allows users to see a list of all the existing activities that are stored in a session.
* [Activity View](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/command/ActivityViewCommand.java)
* What it does: Allows users to view all previously created activities within a session.
* Justification: This features allows users to see the full details of a particular activity.
* [Group](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/data/Group.java)
* Represents a group that involves a list of participants.

#### Enhanced Features
#### Enhancements to existing features:
* Separated dependency of parser class from command class by creating Command Parser classes for certain features.
* These include [GroupCreateCommandParser](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/parser/commandparser/GroupCreateCommandParser.java),
[GroupDeleteCommandParser](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/parser/commandparser/GroupDeleteCommandParser.java),
[GroupEditCommandParser](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/parser/commandparser/GroupEditCommandParser.java),
[ActivityViewCommandParser](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/parser/commandparser/ActivityViewCommandParser.java) and
[ActivityListCommandParser](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/parser/commandparser/ActivityListCommandParser.java) classes.

#### Testing
* Added command `Junit` test for
[GroupCreateCommand](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/test/java/seedu/splitlah/command/GroupCreateCommandTest.java),
[GroupDeleteCommand](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/test/java/seedu/splitlah/command/GroupDeleteCommandTest.java),
[GroupEditCommand](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/test/java/seedu/splitlah/command/GroupEditCommandTest.java),
[ActivityViewCommand](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/test/java/seedu/splitlah/command/ActivityViewCommandTest.java) and
[ActivityListCommand](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/test/java/seedu/splitlah/command/ActivityListCommandTest.java).

### Documentation Contributions
Documentation Contribution:

#### User Guide

* Added documentation for [`Creating a group`](https://ay2122s2-cs2113t-t10-1.github.io/tp/UserGuide.html#creating-a-group-group-create),
[`Deleting a group`](https://ay2122s2-cs2113t-t10-1.github.io/tp/UserGuide.html#deleting-a-group-group-delete),
[`Editing a group`](https://ay2122s2-cs2113t-t10-1.github.io/tp/UserGuide.html#editing-a-group-group-edit),
[`Viewing an activity`](https://ay2122s2-cs2113t-t10-1.github.io/tp/UserGuide.html#viewing-an-activity-activity-view) and
[`Listing an activity`](https://ay2122s2-cs2113t-t10-1.github.io/tp/UserGuide.html#listing-all-activities-in-a-session-activity-list) sections of the User Guide.

#### Developer Guide

### Miscellaneous Contributions

#### Project Management

* Added the explanation for [`Add a group`](https://ay2122s2-cs2113t-t10-1.github.io/tp/DeveloperGuide.html#add-a-group),
[`Remove a group`](https://ay2122s2-cs2113t-t10-1.github.io/tp/DeveloperGuide.html#remove-a-group) and
[`Edit a group`](https://ay2122s2-cs2113t-t10-1.github.io/tp/DeveloperGuide.html#edit-a-gorup) sections of the Developer Guide.
81 changes: 59 additions & 22 deletions docs/team/matheril.md
Original file line number Diff line number Diff line change
@@ -11,30 +11,59 @@ the activities they participated in, for a particular session.
Code Contribution: [RepoSense Link](https://nus-cs2113-ay2122s2.github.io/tp-dashboard/?search=&sort=totalCommits%20dsc&sortWithin=title&timeframe=commit&mergegroup=&groupSelect=groupByRepos&breakdown=true&checkedFileTypes=docs~functional-code~test-code~other&since=2022-02-18&tabOpen=true&tabType=authorship&tabAuthor=matheril&tabRepo=AY2122S2-CS2113T-T10-1%2Ftp%5Bmaster%5D&authorshipIsMergeGroup=false&authorshipFileTypes=docs~functional-code~test-code~other&authorshipIsBinaryFileTypeChecked=false)

#### New Features
* Activity Cost
* This class encapsulates the cost paid and owed for a specific activity by a person.
* Activity Edit
* Allows users to edit an activity, only having to specify the details they wish to change.
* Session View
* Allows users to view a session. Displays session details and a list of the activities involved.
* Text UI
* Acts as a user interface, and offers methods to other classes to print to and read from the user interface.
* Person
* This class represents a person. It encapsulates its `Name` and a list of `ActivityCost`s associated with it.
* Name
* This class represents a name. It sanitises the name used to instantiate it by stripping whitespace from it, and
includes a method that checks if the name is valid (contains only alphabetical characters).
* [Activity Cost](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/data/ActivityCost.java)
* What it does: Encapsulates the cost paid and owed for a specific activity by a person.
* Justification: Allows costs to be tracked per person across multiple activities.
* [Activity Edit](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/command/ActivityEditCommand.java)
* What it does: Edits an activity. Users can specify any number of delimiters while using this command to indicate the details they wish to edit.
Details not specified are left unchanged from the original activity. If the user input does not result in any real changes to the activity (e.g. changing
the activity name to the same name as before), this command informs the user that nothing has been changed.
* Justification: Saves users the effort of having to delete and recreate an activity with incorrect or outdated details.
Editing an activity preserves the unique activity identifier whereas deleting and recreating the activity does not. This makes the
overall experience of editing activites more user friendly and intuitive.
Informing the user when no changes are made helps prevent user error, as editing an activity without changing anything is
very likely to be user error.
* Highlights: This was challenging as activity details are spread out across different components. This made fetching existing details from
the original activity (in case the user does not wish to edit them) difficult.
`Activity` originally did not keep track of GST and service charge values after creation, so changes had to be made to it to store that information.
As activity costs are recalculated and stored with GST and service charge immediately upon creation of an activity, this command
has to reverse these calculations to find the original costs of the activity, in case the user wishes to modify
the GST/service charge values.
Recreating the activity was also difficult, as many methods in other classes rely on `activityId` to do things such as removing
`ActivityCost` objects from `Person` objects. Recreating the activity with the same `activityId` would cause bugs with these
methods, and so a temporary activityId must be used when recreating the activity and changed later after the original has been removed.
Since all the activity detail delimiters are entirely optional when editing an activity, there are several permutations of delimiters
that the user can supply. Each permutation must be handled differently, and some must be rejected outright to prevent bugs.
* [Session View](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/command/SessionViewCommand.java)
* What it does: Views a session. Displays session details and a list of activities involved.
* Justification: Users need a way to get a quick bird's-eye view of a session and the activities involved without
overloading the user with detailed information on every activity.
* [Text UI](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/ui/TextUI.java)
* What it does: Acts as a user interface and has methods that print and read from the user interface.
* Justification: Abstracts the interface away from the different components in SplitLah, allowing developers to code
each component independently of the interface. Changes can be made to the interface without affecting other components.
* [Person](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/data/Person.java)
* What it does: Represents a person. It encapsulates its `Name` and a list of `ActivityCost`s associated with it.
* Justification: People need to be tracked individually and separately from activities to keep track of their costs owed
and paid.
* [Name](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/data/Name.java)
* What it does: Represents a name. It sanitises the name used to instantiate it by stripping whitespace from it, and
checks if the name is valid (contains only alphabetical characters).
* Justification: Can be used by other developers to validate names in a manner that is standardized across all components
that also make use of the `Name` class.

#### Enhanced Features
* Separated dependency of the `Parser` class from the `Command` class by creating `ActivityEditCommandParser` and
`SessionViewCommandParser`.
* TableFormatter
* Separated dependency of parser class from command class by creating Command Parser classes for certain features.
* These include the [ActivityEditCommandParser](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/parser/commandparser/ActivityEditCommandParser.java),
[SessionViewCommandParser](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/parser/commandparser/SessionViewCommandParser.java) classes.
* [TableFormatter](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/ui/TableFormatter.java)
* A `TableFormatter` object creates a table that can be modified with new data at any time. When printed, it
produces a neatly formatted and decorated table that automatically aligns its borders to the data stored within.
Other classes can create `TableFormatter` objects, edit them and pass them to `TextUI` to be printed to the user
interface.
* TableFormatterRow
* A helper class for `TableFormatter`. It represents a single row of the table.
* This allows all developers to print neatly to the interface in a standardized format.
* Makes use of the helper class [TableFormatterRow](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/ui/TableFormatterRow.java) that represents
a single row of the `TableFormatter` object.
* Message
* Set up this class so other developers can store their hardcoded strings in it, such as error and logging messages.
* InvalidDataException
@@ -43,7 +72,11 @@ Code Contribution: [RepoSense Link](https://nus-cs2113-ay2122s2.github.io/tp-das
* Set up this class to represent an exception thrown when format-related errors occur.

#### Testing
* Added JUnit tests for `ActivityEditCommand`,`ActivityEditCommandParser`, `Name`, `Person` and `ActivityCost`.
* Added JUnit tests for [ActivityEditCommand](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/command/ActivityEditCommandTest.java),
[ActivityEditCommandParser](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/parser/commandparser/ActivityEditCommandParserTest.java),
[Name](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/data/NameTest.java),
[Person](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/data/PersonTest.java),
and [ActivityCost](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/src/main/java/seedu/splitlah/data/ActivityCostTest.java).
* As `TextUI` mostly consists of methods that print to the interface instead of returning a value, we decided not to add JUnit tests for this
class.

@@ -52,12 +85,16 @@ Documentation contribution: [RepoSense Link](https://nus-cs2113-ay2122s2.github.

#### User Guide
* Added documentation for `ActivityEditCommand` and `SessionViewCommand`.
* Added documentation for [`Editing an activity`](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/docs/UserGuide.md#editing-an-activity-activity-edit)
and [`Viewing a session`](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/docs/UserGuide.md#viewing-a-session--session-view)
* Wrote sections aimed at introducing users to the program, such as the introduction (SplitLah), the target audience
(Who SplitLah is for) and the basic workflow of the program (How SplitLah works).
* Standardised language and grammar across the guide.
(Who SplitLah is for) and the basic workflow of the program ([How SplitLah works](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/docs/UserGuide.md#how-splitlah-works)).
* Standardised language, grammar and tense across the guide.

#### Developer Guide
* Added documentation for `TextUI`, `SessionViewCommand` and `ActivityEditCommand`.
* Added documentation for [`TextUI`](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/docs/DeveloperGuide.md#textui-component),
[`View a session`](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/docs/DeveloperGuide.md#view-a-session)
and [`ActivityEditCommand`](https://github.com/AY2122S2-CS2113T-T10-1/tp/blob/master/docs/DeveloperGuide.md#edit-an-activity).

### Miscellaneous Contributions
* Recorded and narrated a demo video with slides and annotations including footage of the program in action for use
Loading
Oops, something went wrong.