Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding NUMBA_MLIR_USE_DPNP to setup.py, environment.yml and setenv.sh #42

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chudur-budur
Copy link
Contributor

  • A small modification so that NUMBA_MLIR_USE_DPNP could be used from bash environment variable.
  • setup.py can compile with dpctl headers if NUMBA_MLIR_USE_DPNP=1
  • Adding environment.yml and setenv.sh so that environment replication becomes easy and fast.

Please review these guidelines to help with the review process:

  • Have you provided a meaningful PR description?
  • Have you added a test, a reproducer, or a reference to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?
  • Have you organized your commits logically and ensured each can be built by itself?

@Hardcode84
Copy link
Contributor

I'm ok with setup.py changes, although be don't need them immediately, but evironment.yaml and setup.sh just captures your local environment, I don't think we want to keep them in repo.

@chudur-budur
Copy link
Contributor Author

I'm ok with setup.py changes, although be don't need them immediately, but evironment.yaml and setup.sh just captures your local environment, I don't think we want to keep them in repo.

Okay, fixed it.

@Hardcode84
Copy link
Contributor

pls, fix precommit

@chudur-budur chudur-budur marked this pull request as draft February 19, 2023 21:44
@chudur-budur
Copy link
Contributor Author

chudur-budur commented Feb 19, 2023

converting into draft, since I am doing several modifications in the setup.py so that it can be built in-tree in numba-dpex
please do not merge (now or sooner)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants