-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monorepo #466
Open
funwithtriangles
wants to merge
26
commits into
alpha
Choose a base branch
from
monorepo
base: alpha
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Monorepo #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been to config hell and back! We now have a monorepo, with three packages:
@hedron/engine
(will eventually be on npm)@hedron/desktop
(depends on@hedron/engine
)@hedron/example-project
(still all sorts of type errors here but we can worry about that later)For some boring technical reason we're back to using
yarn
. You can do everything from the root of the project, see the readme file. It's important that@hedron/engine
is built before you start developing, otherwise you'll see a bunch of errors.yarn dev
should do everything for you.Let me know if this is working for you @cale-bradbury. I'm also fully aware how much this is going to mess any PRs you might have coming in. Not sure what's going to be easier to merge first, although I feel like there's less chance of changes getting lost if we merge this first and then you'll have to manually move your changed files into this new system.
Last fixes