Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keep the time field in the abbreviated metadata #24

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zkochan
Copy link

@zkochan zkochan commented Mar 8, 2023

pnpm has implemented a time-based resolution strategy. This resolution strategy needs the time field in the package metadata. Currently, we have to request the full metadata of the package, when this strategy is used. It would be great to have the time field in the non-abbreviated version of the metadata. Verdaccio is already including this field in the non-abbreviated version of the metadata.

This change would be also useful for npm CLI, when the before setting is used.

References

Related to pnpm/rfcs#2
Related to npm/rfcs#549

@zkochan zkochan requested a review from a team as a code owner March 8, 2023 01:03
@zkochan zkochan requested review from fritzy and removed request for a team March 8, 2023 01:03
@wraithgar
Copy link
Member

This won't actually affect the minified packuments in the registry that already exist. Those are calculated and stored at publish time.

@nlf
Copy link

nlf commented Apr 18, 2023

as @wraithgar mentioned, these files are already stored. we do have a process for updating minified content across the registry, but that takes a bit of planning and an assist from our registry team. i'm going to leave this pull request open for now and discuss internally to see if we can get that done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants