fix: fix issue with retrieving repository URL

[marshallku]

- gconf = gconf.split(/\r?\n/)
+ const gconf = await fs.readFile('.git/config', 'utf8').catch(() => '')
+ const lines = gconf.split(/\r?\n/)

In #186, there was breaking change in retrieving repository URL from .git/config.

Although the split lines were assigned to lines, the code still accessed gconf to get the file lines, causing the repository field to never auto-complete.

References

[wraithgar]

We will definitely want a regression test on this one.

[marshallku]

Hi, @wraithgar
The logic is almost same as previous version(before breaking changes), and I just tested locally with my git config file.
Should I write test code for this case?

[wraithgar]

@marshallku yes. The fact that tests didn't fail w/ this bug means the tests are lacking here. We need some test that would fail w/ the old code but succeed w/ the new code.

[wraithgar]

It may be as simple as an assertion in an existing test that wasn't looking at the affected attributes. I haven't dug in to be sure.

[marshallku]

@wraithgar I add test case for retriving URL of remote repository.
I used git config --get remote.origin.url in runtime to get the expected output.
Let me know if it would be better to hard-code https://github.com/npm/init-package-json.git.

[wraithgar]

We don't need to hard code it, but the test should probably be doing the same thing that the code itself is doing, namely looking in the git config file to find the right value.

We'll have to hope that file is present in CI. We've had tests in the past that were coupled to the actual .git content of the source, which failed in some test setups. If that happens we'll have to generate a new test fixture directory for this test and manually write that file.

ETA: Yep, tests fail in CI cause the remote is subtly different than you have locally. We'll want to use a tap testdir here so we can control what goes into that file.

[marshallku]

Thanks for leading @wraithgar.
I used testdir, and add more cases to verify logics.

[marshallku]

Hi @wraithgar

I wanted to kindly remind you about the pull request I submitted. Your feedback is highly valuable, and I’d appreciate it if you could take some time to review it.

[wraithgar]

superceded by #315