fix: decrease web app loading time #1147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbuljac
force-pushed
the
fix/decrease-loading-time
branch
2 times, most recently
from
5bab923 to
5d5d131
Compare
sbuljac
force-pushed
the
fix/decrease-loading-time
branch
from
5d5d131 to
d735584
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scripting takes a lot of time when app is loaded firs time, most of the heavy computation lies in the client registries, by implementing simple cash logic I was able to reduce scripting time from ~15sec to ~6sec (tested locally with web:serve).
Ideally we would completely refactor registries to reduce complexity and increase performance but maybe this will do for now.
@jeffywu I can also change cashing logic so it expires after 20-30 sec(first load) if you think it is necessary
Note: additional improvements can be made if you are ok with this type of caching/optimization
Before:
After: