Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github actions and style checks #34

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Github actions and style checks #34

merged 1 commit into from
Nov 30, 2020

Conversation

wtrocki
Copy link
Member

@wtrocki wtrocki commented Nov 10, 2020

Motivation

Detect markdown issues and style issues on PR level by adding github actions capability.
This can be extended later to include extra styling for website etc.

This resolves first part of the #21

@wtrocki
Copy link
Member Author

wtrocki commented Nov 10, 2020

Actual style changes can be discussed and adjusted (to some extend) etc.

Copy link
Contributor

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once rebased.

@wtrocki wtrocki force-pushed the github-style-checks branch 2 times, most recently from 975a2f6 to b7c6608 Compare November 30, 2020 17:42
@wtrocki
Copy link
Member Author

wtrocki commented Nov 30, 2020

Rebased. Good to merge

@wtrocki
Copy link
Member Author

wtrocki commented Nov 30, 2020

Build is passing now and all styles were updated.
Thank you for review

@wtrocki wtrocki merged commit b1baa5b into master Nov 30, 2020
@wtrocki wtrocki deleted the github-style-checks branch November 30, 2020 22:34
@mhdawson
Copy link
Contributor

@wtrocki thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants