Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add npcheck Q3 review #171

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Conversation

lholmquist
Copy link
Member

nothing much here. A module added a dependency which needed its license added to the list


(40): The module "@openapitools/openapi-generator-cli" depends on the "[email protected]" package which is under the non-acceptable license "BlueOak-1.0.0". - ERROR

The latest release of `@openapitools/openapi-generator-cli` added the `glob` module which includes `path-scurry` which had a license(BlueOak-1.0.0) that was not in the list. It has now been added to the list.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make it a bit more obvious that the npcheck reports are now green.

Copy link
Contributor

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lholmquist lholmquist merged commit e3a8e82 into nodeshift:main Oct 17, 2024
1 check passed
@lholmquist lholmquist deleted the npcheck-q3-2024 branch October 17, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants