Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: converts args to std::span<std::string_view> #56083

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

src: converts args to std::span<std::string_view> #56083

wants to merge 1 commit into from
+118 −112

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Nov 29, 2024

Work in progress.

The goal is to convert std::vector<std::string> to std::span<std::string_view>

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/single-executable
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Nov 29, 2024
@addaleax addaleax added the semver-major PRs that contain breaking changes and should be released in the next major version. label Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anonrig @nodejs-github-bot @addaleax