Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: support blocklist for net.Server #56079

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

net: support blocklist for net.Server #56079

wants to merge 1 commit into from

Conversation

theanarkh
Copy link
Contributor

Support blocklist options for net.Server, which can be used for disabling inbound access to specific IP addresses, IP ranges, or IP subnets.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. labels Nov 29, 2024
@theanarkh theanarkh force-pushed the support_blocklist_in_net_server branch from 0720545 to 4ecdf03 Compare November 29, 2024 16:36
lpinca
lpinca reviewed Nov 29, 2024
View reviewed changes
lib/net.js Show resolved Hide resolved
@lpinca lpinca added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 29, 2024
@theanarkh theanarkh force-pushed the support_blocklist_in_net_server branch from 4ecdf03 to 83871b6 Compare November 29, 2024 17:10
@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.99%. Comparing base (4cf6fab) to head (1bb4c67).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
lib/net.js 81.25% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56079      +/-   ##
==========================================
- Coverage   88.00%   87.99%   -0.01%     
==========================================
  Files         656      656              
  Lines      188988   189015      +27     
  Branches    35992    35996       +4     
==========================================
+ Hits       166315   166322       +7     
- Misses      15838    15849      +11     
- Partials     6835     6844       +9
Files with missing lines Coverage Δ
lib/net.js 92.81% <81.25%> (-0.08%) ⬇️

... and 25 files with indirect coverage changes

lpinca
lpinca reviewed Nov 29, 2024
View reviewed changes
doc/api/net.md Outdated Show resolved Hide resolved
@theanarkh theanarkh force-pushed the support_blocklist_in_net_server branch 2 times, most recently from 136ecd7 to a1321f0 Compare November 29, 2024 19:43
@theanarkh theanarkh force-pushed the support_blocklist_in_net_server branch from a1321f0 to 1bb4c67 Compare November 30, 2024 02:17
@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63810/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63813/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63815/

mcollina
mcollina approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca left review comments

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@theanarkh @nodejs-github-bot @mcollina @jasnell @lpinca