Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: validate undefined sizeAlgorithm in WritableStream #56067

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jazelly
Copy link
Member

@jazelly jazelly commented Nov 29, 2024

No test was added since it was covered by existing WPT, and the spec change did not introduce WPT updates

Fixes: #56014
Refs: whatwg/streams#1333

@jazelly jazelly added web streams web-standards Issues and PRs related to Web APIs labels Nov 29, 2024
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 29, 2024
@jazelly jazelly added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@jazelly jazelly removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.00%. Comparing base (4cf6fab) to head (fce3fd9).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #56067   +/-   ##
=======================================
  Coverage   88.00%   88.00%           
=======================================
  Files         656      656           
  Lines      188988   188997    +9     
  Branches    35992    35991    -1     
=======================================
+ Hits       166315   166324    +9     
+ Misses      15838    15832    -6     
- Partials     6835     6841    +6     
Files with missing lines Coverage Δ
lib/internal/webstreams/writablestream.js 99.85% <100.00%> (+<0.01%) ⬆️

... and 27 files with indirect coverage changes

@jazelly jazelly added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 30, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. web streams web-standards Issues and PRs related to Web APIs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streams: writableStreamDefaultControllerGetChunkSize undefined strategy case slightly broken
2 participants