fs: make mutating options in readdir() not affect results
#56057
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56057 +/- ##
==========================================
- Coverage 88.00% 87.97% -0.03%
==========================================
Files 653 656 +3
Lines 187872 188395 +523
Branches 35888 35972 +84
==========================================
+ Hits 165328 165737 +409
- Misses 15720 15840 +120
+ Partials 6824 6818 -6
|
|
To be safe, Callback API test blocked until #56041 lands (the test can be moved to that PR). |
RafaelGSS
approved these changes
Nov 29, 2024
lpinca
approved these changes
Nov 30, 2024
mertcanaltin
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback version is implemented in sync way (see #56006), so its test should pass without adjustments.