Allow manipulating the generator in Duplex.from()

[matthieusieben]

Fix for #55077

[mcollina]

lgtm with a few nits, good job

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/62727/

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.00%. Comparing base (4efb7ae) to head (d660809).
Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #55096   +/-   ##
=======================================
  Coverage   87.99%   88.00%           
=======================================
  Files         656      656           
  Lines      188988   189033   +45     
  Branches    35988    35995    +7     
=======================================
+ Hits       166302   166350   +48     
+ Misses      15848    15844    -4     
- Partials     6838     6839    +1     

Files with missing lines	Coverage Δ
lib/internal/streams/duplexify.js	97.16% <100.00%> (+0.59%)	⬆️

... and 29 files with indirect coverage changes

[matthieusieben]

Not sure how to fix the breaking test(s):

test-stream-compose-operator

=== release test-stream-compose-operator ===
Path: parallel/test-stream-compose-operator
node:internal/process/promises:394
    triggerUncaughtException(err, true /* fromPromise */);
    ^

AssertionError [ERR_ASSERTION]: The input did not match the regular expression /boom/. Input:

'AbortError: The operation was aborted'

    at process.processTicksAndRejections (node:internal/process/task_queues:105:5) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: AbortError: The operation was aborted
      at destroyer (node:internal/streams/destroy:328:11)
      at node:internal/streams/duplexify:89:7
      at asyncGenerator.return (node:internal/streams/duplexify:245:9)
      at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
      at async /Users/msi/Github/nodejs/node/test/parallel/test-stream-compose-operator.js:63:5
      at async nextAsync (node:internal/streams/from:182:33) {
    code: 'ABORT_ERR'
  },
  expected: /boom/,
  operator: 'rejects'
}

Node.js v23.0.0-pre
Command: out/Release/node /Users/msi/Github/nodejs/node/test/parallel/test-stream-compose-operator.js

Fixed thanks to @jazelly 🙏

[ronag]

@benjamingr This seems super hacky... wdyt?

[matthieusieben]

@ronag I agree. I don't usually like to monkey patch stuff but in this case I coudn't think of another way...

I tried using a try/catch/finally block inside the async generator to do the same. But since those block don't get called unless an iteration started (next() called at least once), that didn't work.

[jasnell]

Nit: I'd really prefer if we could start adding a bit more documentation to each individual test that briefly describes what is expected and what that test is verifying.

[matthieusieben]

Sorry but I don't have more time to work on this at the moment. Will definitely think about it the next time I open a PR.

[jazelly]

This PR needs a rebase

[mcollina]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63772/

[matthieusieben]

Just rebased and fixed conflicts.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63804/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63811/