Skip to content

Commit

Permalink
chore: prepare v1.1 (#10)
Browse files Browse the repository at this point in the history
  • Loading branch information
johnletey authored Apr 29, 2024
1 parent efeea8d commit dd5f499
Show file tree
Hide file tree
Showing 9 changed files with 37 additions and 3 deletions.
1 change: 1 addition & 0 deletions .changelog/config.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
project_url = "https://github.com/noble-assets/forwarding"
Empty file added .changelog/unreleased/.gitkeep
Empty file.
5 changes: 5 additions & 0 deletions .changelog/v1.0.0/summary.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
*Apr 24, 2024*

This is a standalone release of the `x/forwarding` module introduced to Noble's codebase in the `v4.1.0` Fusion release.

The module has been ported from [noble-assets/noble@`bb9ee09`](https://github.com/noble-assets/noble/commit/bb9ee097f09ce3e923242e9bac3ac997f0d44f8b), which was the latest commit hash that [Halborn](https://www.halborn.com) audited. We have additionally upstreamed [noble-assets/noble#350](https://github.com/noble-assets/noble/pull/350), which introduces a small fix to the forwarding IBC middleware.
1 change: 1 addition & 0 deletions .changelog/v1.1.0/bug-fixes/8-genesis-account.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Register forwarding accounts as a `GenesisAccount` implementation. ([#8](https://github.com/noble-assets/forwarding/pull/8))
1 change: 1 addition & 0 deletions .changelog/v1.1.0/features/5-stats-query.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Implement generic stats query across all channels. ([#5](https://github.com/noble-assets/forwarding/pull/5))
3 changes: 3 additions & 0 deletions .changelog/v1.1.0/summary.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
*Apr 29, 2024*

This is a minor, non-consensus breaking, release to the `v1` line.
24 changes: 24 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
# CHANGELOG

## v1.1.0

*Apr 29, 2024*

This is a minor, non-consensus breaking, release to the `v1` line.

### BUG FIXES

- Register forwarding accounts as a `GenesisAccount` implementation. ([#8](https://github.com/noble-assets/forwarding/pull/8))

### FEATURES

- Implement generic stats query across all channels. ([#5](https://github.com/noble-assets/forwarding/pull/5))

## v1.0.0

*Apr 24, 2024*

This is a standalone release of the `x/forwarding` module introduced to Noble's codebase in the `v4.1.0` Fusion release.

The module has been ported from [noble-assets/noble@`bb9ee09`](https://github.com/noble-assets/noble/commit/bb9ee097f09ce3e923242e9bac3ac997f0d44f8b), which was the latest commit hash that [Halborn](https://www.halborn.com) audited. We have additionally upstreamed [noble-assets/noble#350](https://github.com/noble-assets/noble/pull/350), which introduces a small fix to the forwarding IBC middleware.

1 change: 0 additions & 1 deletion proto/noble/forwarding/v1/query.proto
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ service Query {
}

rpc Stats(QueryStats) returns (QueryStatsResponse) {
// NOTE: This is intentionally not a module safe query.
option (google.api.http).get = "/noble/forwarding/v1/stats";
}

Expand Down
4 changes: 2 additions & 2 deletions x/forwarding/types/account.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@ func GenerateAddress(channel string, recipient string) sdk.AccAddress {

func (fa *ForwardingAccount) Validate() error {
if !channeltypes.IsValidChannelID(fa.Channel) {
return fmt.Errorf("channel id (%s) is invalid for account %s", fa.Channel, fa.Address)
return fmt.Errorf("%s is an invalid channel id", fa.Channel)
}

if fa.CreatedAt < 0 {
return fmt.Errorf("%d is an invalid creation height for account %s", fa.CreatedAt, fa.Address)
return fmt.Errorf("%d is an invalid creation block height", fa.CreatedAt)
}

return fa.BaseAccount.Validate()
Expand Down

0 comments on commit dd5f499

Please sign in to comment.