Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins/markview: init #2000

Merged
merged 1 commit into from
Aug 12, 2024
Merged

plugins/markview: init #2000

merged 1 commit into from
Aug 12, 2024

Conversation

khaneliman
Copy link
Contributor

@khaneliman khaneliman mentioned this pull request Aug 10, 2024
Merged
13 tasks
@khaneliman khaneliman force-pushed the markview branch 2 times, most recently from 7128a7e to e4c5786 Compare August 10, 2024 13:58
@khaneliman khaneliman mentioned this pull request Aug 10, 2024
Draft
MattSturgeon
MattSturgeon approved these changes Aug 10, 2024
View reviewed changes
Copy link
Member

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major issues from me

tests/test-sources/plugins/languages/markdown/markview.nix Show resolved Hide resolved
@MattSturgeon

This comment was marked as resolved.

Sign in to view
GaetanLepage
GaetanLepage requested changes Aug 12, 2024
View reviewed changes
Copy link
Member

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stylistic remarks.

plugins/languages/markdown/markview.nix Outdated Show resolved Hide resolved
plugins/languages/markdown/markview.nix Outdated Show resolved Hide resolved
plugins/languages/markdown/markview.nix Outdated Show resolved Hide resolved
tests/test-sources/plugins/languages/markdown/markview.nix Outdated Show resolved Hide resolved
GaetanLepage
GaetanLepage approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked all options explicitly, but the module looks good to me overall.

@GaetanLepage
Copy link
Member

@Mergifyio queue

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 12, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d9055ab

@mergify mergify bot merged commit d9055ab into nix-community:main Aug 12, 2024
4 checks passed
@khaneliman khaneliman deleted the markview branch August 12, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattSturgeon MattSturgeon MattSturgeon approved these changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khaneliman @MattSturgeon @GaetanLepage