Backslashing constants too

nilportugues · Nov 3, 2015 · 4e1b8f9 · 4e1b8f9
1 parent 8564b7f
commit 4e1b8f9
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 7 deletions.
diff --git a/src/BackslashFixer/Command/FixerCommand.php b/src/BackslashFixer/Command/FixerCommand.php
@@ -41,7 +41,7 @@ protected function configure()
      * @param InputInterface  $input  Input
      * @param OutputInterface $output Output
      *
-     * @return int|null|void
+     * @return int|\null|void
      *
      * @throws Exception
      */
@@ -58,7 +58,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
             $fileEditor->addBackslashesToFunctions($file);
         }
 
-        $output->write('Success!', true);
+        $output->write('Success!', \true);
 
         return $output;
     }

diff --git a/src/BackslashFixer/Fixer/FileEditor.php b/src/BackslashFixer/Fixer/FileEditor.php
@@ -19,6 +19,11 @@ class FileEditor
      */
     private static $characters = [" ", "(", ",", "!", "[", "="];
 
+    /**
+     * @var array
+     */
+    private static $constants = [];
+
     /**
      *
      */
@@ -44,6 +49,8 @@ public function addBackslashesToFunctions($path)
             $source = \str_replace($functions, $this->buildBackslashedFunctions($character), $source);
         }
 
+        $source = \str_replace($this->getDefinedConstants(), $this->replaceConstants(), $source);
+        $source = \str_replace(['true', 'false', 'null'], ['\true', '\false', '\null'], $source);
         $source = \str_replace("function \\", "function ", $source);
 
         \file_put_contents($path, $source);
@@ -136,4 +143,27 @@ private function buildFunctions($previousCharacter = ' ')
         $functions = \array_map($callback, $functions);
         return $functions;
     }
+
+    /**
+     * @return array
+     */
+    private function replaceConstants()
+    {
+        $constants = $this->getDefinedConstants();
+        $callback  = function ($v) {
+            return sprintf('\%s', $v);
+        };
+        return \array_map($callback, $constants);
+    }
+
+    /**
+     * @return array
+     */
+    private function getDefinedConstants()
+    {
+        if(empty(self::$constants)) {
+            self::$constants = \array_keys(\get_defined_constants(\false));
+        }
+        return self::$constants;
+    }
 }
diff --git a/src/BackslashFixer/Fixer/PhpFilesRepository.php b/src/BackslashFixer/Fixer/PhpFilesRepository.php
@@ -18,7 +18,7 @@ class PhpFilesRepository
 {
     public function find($path)
     {
-        if (false === \is_dir($path) && false === \is_file($path)) {
+        if (\false === \is_dir($path) && \false === \is_file($path)) {
             throw new InvalidArgumentException("Provided input is not a file nor a valid directory");
         }
 

diff --git a/src/bootstrap.php b/src/bootstrap.php
@@ -2,13 +2,13 @@
 
 function includeIfExists($file)
 {
-    return \file_exists($file) ? include $file : false;
+    return \file_exists($file) ? include $file : \false;
 }
 
 if ((!$loader = includeIfExists(__DIR__ . '/../vendor/autoload.php')) && (!$loader = includeIfExists(__DIR__ . '/../../../autoload.php'))) {
-    echo 'You must set up the project dependencies, run the following commands:' . PHP_EOL .
-        'curl -sS https://getcomposer.org/installer | php' . PHP_EOL .
-        'php composer.phar install' . PHP_EOL;
+    echo 'You must set up the project dependencies, run the following commands:' . \PHP_EOL .
+        'curl -sS https://getcomposer.org/installer | php' . \PHP_EOL .
+        'php composer.phar install' . \PHP_EOL;
     exit(1);
 }