Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from mitchellh/mapstructure to go-viper/mapstructure #69

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Conversation

ktong
Copy link
Collaborator

@ktong ktong commented Jan 7, 2024

Reference: mitchellh/mapstructure#349 (comment)

mitchellh stops the maintenance for mapstructure and other mitchellh/mapstructure#349 (comment).

The mapstructure project is already forked by viper project, since they have a strong dependency against it.

https://github.com/go-viper/mapstructure

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Merging #69 (df80036) into main (6953fb7) will increase coverage by 3.33%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   72.07%   75.40%   +3.33%     
==========================================
  Files          17       17              
  Lines         666      618      -48     
==========================================
- Hits          480      466      -14     
+ Misses        175      141      -34     
  Partials       11       11              
Components Coverage Δ
konf 93.76% <100.00%> (+7.73%) ⬆️
file 71.11% <ø> (ø)
pflag 40.57% <ø> (ø)
Files Coverage Δ
config.go 94.44% <100.00%> (+14.92%) ⬆️
option.go 33.33% <ø> (ø)

@ktong ktong merged commit ef74c14 into main Jan 7, 2024
16 checks passed
@ktong ktong deleted the kt_ms branch January 7, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant