-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative PivotUI2 function #1046
Open
bseddon
wants to merge
9
commits into
nicolaskruchten:master
Choose a base branch
from
bseddon:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Nov 9, 2018
-
PivotUI generates HTML using a table which has a fixed layout. The alternative UI generates a set of <div> tags. The presentation of these tags can be defined using only CSS. The updated ./dist/pivot.css includes CSS that create a facsimile of the table presentation. The facsimile is not exactly the same but it can be with a little more effort.
Configuration menu - View commit details
-
Copy full SHA for 7520422 - Browse repository at this point
Copy the full SHA 7520422View commit details -
Adds styles to provide a default presentation for PivotUI2
The styles create a presentation that is a facsimile of the PivotUI table based layout. The facsimile is similar to the table layout but not identical - but it could be with a bit more effort, It is provided to illustrate how the generated <div> tags can be manipulated.
Configuration menu - View commit details
-
Copy full SHA for 0e1638f - Browse repository at this point
Copy the full SHA 0e1638fView commit details -
Update gulp-git reference version number
Version 0.5.5 references a version of require-dir that uses invalid node because some properties were deprecated in node 8.x. gulp-git version 2.8.0 references require-dir 1.0.0 which doesn't use the invalid property.
Configuration menu - View commit details
-
Copy full SHA for b1de9d7 - Browse repository at this point
Copy the full SHA b1de9d7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7fe3db - Browse repository at this point
Copy the full SHA f7fe3dbView commit details -
The 'natives' package is required
It is required to prevent a gulp crash with the message: '''gulp[16200]: src\node_contextify.cc:628: Assertion `args[1]->IsString()' failed.```
Configuration menu - View commit details
-
Copy full SHA for bda356a - Browse repository at this point
Copy the full SHA bda356aView commit details
Commits on Nov 12, 2018
-
Now there is one UI function. The layout HTML generated can be <table> based or <div> based depending upon the value of a new option called 'tag'. This option can have the value of 'table' (the default) or 'div'.
Configuration menu - View commit details
-
Copy full SHA for 052b926 - Browse repository at this point
Copy the full SHA 052b926View commit details -
Further modified to use inline if then ... else ... statements which has the effect of slimming the changes made.
Configuration menu - View commit details
-
Copy full SHA for 6e6e382 - Browse repository at this point
Copy the full SHA 6e6e382View commit details -
Added support for a responsive layout but adding the 'responsive' tag which takes values true or false. This option only had an effect when the 'tag' option is set to 'div'
Configuration menu - View commit details
-
Copy full SHA for be84cce - Browse repository at this point
Copy the full SHA be84cceView commit details -
Updated the CSS for the <div> layout to more closely resemble the table layout. Also added directives to illustrate how the <div> layout can be responsive. The directive change the layout to a stacked presentation when the display device is a handheld one such as a mobile phone or if the page width is 800px or less.
Configuration menu - View commit details
-
Copy full SHA for e05654b - Browse repository at this point
Copy the full SHA e05654bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.