Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

environ: Support variable names containing dots #240

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mschmitzer
Copy link

This is useful for transporting arbitrary settings to applications. It is difficult to implement because shell variable names apparently may not contain dots, but environment variables may. Solving this by parsing the variable name with shlex and re-joining the tokens would swallow white space and thus turn "FOO BAR=baz" into a valid assignment. So use everything up to the assignment operator verbatim as the variable name and only shlex the value.

Environment variables containing dots are handled fine by e.g. the env command and the subprocess module.

This is useful for transporting arbitrary settings to applications. It
is difficult to implement because shell variable names apparently may
not contain dots, but _environment_ variables may. Solving this by
parsing the variable name with `shlex` and re-joining the tokens would
swallow whitespace and thus turn "FOO BAR=baz" into a valid
assignment. So use everything up to the assignment operator verbatim
as the variable name and only shlex the value.

Environment variables containing dots are handled fine by e.g. the `env`
command and the `subprocess` module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant