Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate token stories to nimble table #2372

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

rajsite
Copy link
Member

@rajsite rajsite commented Sep 3, 2024

Pull Request

🤨 Rationale

The end goal was to make it easier to capture evaluated token values for static css users (LabVIEW HTML Diff Reports / Gainsights). The idea was:

  • Requiring an SCSS build config is not out of reach for the teams but does not add additional value. They have very manual integration workflows (copy to gainsights web ui?, copy into labview diagram?).
  • Intended workflow is:
    • Open the token stories, configure the controls for CSS Tokens and a theme
    • Enable table multiselect to choose your tokens of interest
    • Use the table action menu to download the tokens as a css file
      • Potentially two options, one for current config based computed tokens and one for computed tokens with prefers-color-scheme detection for light and dark mode

👩‍💻 Implementation

Remaining work:

  • Clean-up templates for custom table column
    • Move styles to separate styles and use classes, etc, for the different template modes
    • Use the tooltip to show a "larger render" version (potentially optional)
    • Clean-up styling for column view, maybe large fonts should render centered
    • Add sizing mixin
  • Add the action menu
    • Fix the calculated style target. It is currently document.documentElement so never reports the correct thing
    • Add the download command

🧪 Testing

✅ Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant