Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix linting on meta.yml files #7121

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

alanmmobbs93
Copy link
Contributor

@alanmmobbs93 alanmmobbs93 commented Nov 29, 2024

PR checklist

Continues NACHO_QC and NACHO_NORMALIZE

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Fix linting problems on meta.yml files.

NOTE: linting on this modules with nf-core modules lint did not thow errors. However, after applying them to Nanostring pipeline and running nf-core pipelines lint, it changed these two files. So, this changed the files there causing a mismatch with nf-core repository.

nf-core version used on pipeline: 3.0.2 (Gitpod session)
nf-core version used on modules: 3.0.3dev0 (Gitpod session)

@alanmmobbs93 alanmmobbs93 added this pull request to the merge queue Nov 29, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2024
@alanmmobbs93 alanmmobbs93 added this pull request to the merge queue Nov 29, 2024
Merged via the queue into nf-core:master with commit e69c465 Nov 29, 2024
23 checks passed
@alanmmobbs93 alanmmobbs93 deleted the nacho_fix_linting branch November 29, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants