Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module: COPTR/EXTRACT #7089

Merged
merged 11 commits into from
Dec 3, 2024
Merged

New module: COPTR/EXTRACT #7089

merged 11 commits into from
Dec 3, 2024

Conversation

ramirobarrantes
Copy link
Contributor

@ramirobarrantes ramirobarrantes commented Nov 25, 2024

PR checklist

Initial addition of module coptr/extract, fourth of five modules for the coptr package

  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
    Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    For modules:
    - [X] nf-core modules test --profile docker
    - [X] nf-core modules test --profile singularity
    - [X] nf-core modules test --profile conda

modules/nf-core/coptr/extract/main.nf Outdated Show resolved Hide resolved
modules/nf-core/coptr/extract/tests/main.nf.test Outdated Show resolved Hide resolved
modules/nf-core/coptr/extract/main.nf Show resolved Hide resolved
modules/nf-core/coptr/extract/main.nf Outdated Show resolved Hide resolved
@itrujnara itrujnara changed the title Initial addition New module: COPTR/EXTRACT Dec 2, 2024
Copy link
Contributor

@SPPearce SPPearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Comment on lines +43 to +45
"${task.process}":
"${task.process}":
coptr: \$(coptr |& sed -E '11!d ; s/CoPTR.*?\\(v(.*?)\\).*/\\1/')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"${task.process}":
"${task.process}":
coptr: \$(coptr |& sed -E '11!d ; s/CoPTR.*?\\(v(.*?)\\).*/\\1/')
"${task.process}":
coptr: \$(coptr |& sed -E '11!d ; s/CoPTR.*?\\(v(.*?)\\).*/\\1/')

@ramirobarrantes ramirobarrantes added this pull request to the merge queue Dec 3, 2024
Merged via the queue into master with commit f25bd4b Dec 3, 2024
33 checks passed
@ramirobarrantes ramirobarrantes deleted the extract branch December 3, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants