Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Module: NACHO_NORMALISE #7100

Merged
merged 23 commits into from
Nov 29, 2024

Conversation

alanmmobbs93
Copy link
Contributor

@alanmmobbs93 alanmmobbs93 commented Nov 26, 2024

PR checklist

Closes Nanostring #111

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

Do you know who wrote the original local module for the Nanostring? So we can give propper credit

Copy link
Contributor

@nschcolnicov nschcolnicov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Copy link
Contributor

@atrigila atrigila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job :) made a few suggestions according to guidelines

modules/nf-core/nacho/normalise/environment.yml Outdated Show resolved Hide resolved
modules/nf-core/nacho/normalise/main.nf Outdated Show resolved Hide resolved
modules/nf-core/nacho/normalise/meta.yml Outdated Show resolved Hide resolved
modules/nf-core/nacho/normalise/meta.yml Outdated Show resolved Hide resolved
modules/nf-core/nacho/normalise/meta.yml Outdated Show resolved Hide resolved
modules/nf-core/nacho/normalise/tests/main.nf.test Outdated Show resolved Hide resolved
modules/nf-core/nacho/normalise/main.nf Outdated Show resolved Hide resolved
modules/nf-core/nacho/normalise/main.nf Outdated Show resolved Hide resolved
modules/nf-core/nacho/normalise/meta.yml Outdated Show resolved Hide resolved
modules/nf-core/nacho/normalise/tests/test.tap Outdated Show resolved Hide resolved
@atrigila
Copy link
Contributor

You have a few linting issues that you can solve checking: nf-core modules lint nacho/normalise

@alanmmobbs93 alanmmobbs93 added the new module Adding a new module label Nov 27, 2024
@alanmmobbs93 alanmmobbs93 changed the title Newmodule nacho normalise New Module: NACHO_NORMALISE Nov 27, 2024
@@ -0,0 +1,61 @@
nextflow.enable.moduleBinaries = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to have this added into the tests/nextflow.config file and then adding the line "config "./nextflow.config" to the main.nf.test file. Just because the docs https://www.nextflow.io/docs/latest/module.html#module-binaries say to add them in the config or pipeline file, and also because no other module seems to set this type of parameters directly in the main.nf file

Copy link
Contributor

@nschcolnicov nschcolnicov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me!

@alanmmobbs93 alanmmobbs93 added this pull request to the merge queue Nov 29, 2024
Merged via the queue into nf-core:master with commit 8aa4eca Nov 29, 2024
25 checks passed
@alanmmobbs93 alanmmobbs93 deleted the newmodule_nacho_normalise branch November 29, 2024 11:54
@alanmmobbs93 alanmmobbs93 mentioned this pull request Nov 29, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new module Adding a new module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate NACHO_NORMALISE to nf-core
4 participants