-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Module: NACHO_NORMALISE #7100
New Module: NACHO_NORMALISE #7100
Conversation
Update from master branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job :) made a few suggestions according to guidelines
You have a few linting issues that you can solve checking: |
…obbs93/modules into newmodule_nacho_normalise
…obbs93/modules into newmodule_nacho_normalise
@@ -0,0 +1,61 @@ | |||
nextflow.enable.moduleBinaries = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to have this added into the tests/nextflow.config file and then adding the line "config "./nextflow.config" to the main.nf.test file. Just because the docs https://www.nextflow.io/docs/latest/module.html#module-binaries say to add them in the config or pipeline file, and also because no other module seems to set this type of parameters directly in the main.nf file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good to me!
PR checklist
Closes Nanostring #111
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
Do you know who wrote the original local module for the Nanostring? So we can give propper credit