Dev -> Master 2.7.0 #420
Open
Dev -> Master 2.7.0 #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
post-release dev bump version and snapshots
add missing comma
Important! Template update for nf-core/tools v2.12
Fix/samplename join
Following the template
Important! Template update for nf-core/tools v2.13
Important! Template update for nf-core/tools v2.13.1
Samplesheet input section was duplicated
remove duplicate section from usage.md
This should now have both unique samples and samples that need to be merged for both single-end and paired-end scenarios.
Switching R1 and R2 round for the last test merge, which should also work (both for merging and for processing even though it won't align in directional mode).
update bismark+bwameth modules; sub-wf; wf
|
do not merge until confirmation of test_full runs |
udpate tests to use nft-bam for bam files
update SAMTOOLS_FAIDX fasta input after reorg
maxulysse
reviewed
Oct 18, 2024
maxulysse
reviewed
Oct 18, 2024
maxulysse
reviewed
Oct 18, 2024
maxulysse
reviewed
Oct 18, 2024
maxulysse
reviewed
Oct 18, 2024
Comment on lines
+49
to
+53
| { assert workflow.success }, | ||
| { assert snapshot( | ||
| // Number of tasks | ||
| workflow.trace.succeeded().size() | ||
| ).match() } |
There was a problem hiding this comment.
they are there...plz check again
https://github.com/nf-core/methylseq/blob/0b8372017fad8e7f8cdc65a63baa326381ce8d60/tests/default.nf.test.snap
maxulysse
reviewed
Oct 18, 2024
Comment on lines
+51
to
+55
| { assert workflow.success }, | ||
| { assert snapshot( | ||
| // Number of tasks | ||
| workflow.trace.succeeded().size() | ||
| ).match() } |
maxulysse
reviewed
Oct 18, 2024
Comment on lines
+51
to
+55
| { assert workflow.success }, | ||
| { assert snapshot( | ||
| // Number of tasks | ||
| workflow.trace.succeeded().size() | ||
| ).match() } |
maxulysse
reviewed
Oct 18, 2024
maxulysse
reviewed
Oct 18, 2024
maxulysse
reviewed
Oct 18, 2024
maxulysse
reviewed
Oct 18, 2024
maxulysse
reviewed
Oct 18, 2024
maxulysse
reviewed
Oct 18, 2024
|
|
||
| // location of an optional nextflow.config file specific for executing tests | ||
| configFile "nextflow.config" | ||
| configFile "tests/nextflow.config" |
There was a problem hiding this comment.
what else do you have there that's not already in the profile test?
There was a problem hiding this comment.
maxulysse
reviewed
Oct 18, 2024
| profile "test" | ||
|
|
||
| // List of filenames or patterns that should be trigger a full test run | ||
| triggers 'nextflow.config', 'nf-test.config', 'conf/test.config', 'conf/test_full.config' |
There was a problem hiding this comment.
the nf files are automatically detected by nf-test with the --changed-since feature in the CI
the triggers here meanwhile will make sure all tests are run if any of the trigger files are changed
maxulysse
reviewed
Oct 18, 2024
apply code review suggestions and activate igenomes bwameth index use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.