fix: improve R1CS folding test to verify cross-terms #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test previously only checked folding of identical instances, missing cross-term verification. Description ----------- Now it: - Tests different R1CS instances (x=3 and x=-2) - Explicitly verifies cross-term computation (Az₁Bz₂ + Az₂Bz₁ - u₁Cz₂ - u₂Cz₁) - Verifies the complete folding operation with different instances Testing the introduced fix -------------------------- clone this pr branch and from the root directory, run: ---- cargo test --package nexus-nova --lib -- r1cs::tests::folded_with_relaxed_instance_is_satisfied --exact --show-output ----
|
Thank you for this, we will review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test previously only checked folding of identical instances, missing cross-term verification.
Description
Now it:
R1CSinstances(x=3 and x=-2)(Az₁Bz₂ + Az₂Bz₁ - u₁Cz₂ - u₂Cz₁)Testing the introduced
fixclone this pr branch and from the root directory, run:
Impact
This PR closes ticket #288