-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Github Action cache to improve CI time #269
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
8e3cc1b
to
72fe24a
Compare
2fc583b
to
9cd444e
Compare
d03cd64
to
97853d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that current CI configuration already caches compile artifacts, from main branch test workflow:
... Restoring cache ...
Received 22[229](https://github.com/nexus-xyz/nexus-zkvm/actions/runs/10273767219/job/28429080317#step:3:239)8112 of 509254757 (43.7%), 211.6 MBs/sec
Received 478150656 of 509254757 (93.9%), 227.8 MBs/sec
Cache Size: ~486 MB (509254757 B)
It does appear to not work now, might be a misconfiguration issue or something else. Quick search gives https://github.com/actions/cache/blob/main/tips-and-workarounds.md#use-cache-across-feature-branches
Tearing out the whole thing isn't proper solution, as there's no guarantee it will not happen again (especially because two workflows function the same way).
Secondly, the whole CI configuration now looks very cluttered compared to main.
Hmm, I didn't know we have build cache, perhaps because I only look at build time in CI. When I made this PR, I notice the build time improve. I separate the clippy, because this way we have code scanning features and can be viewed overtime in Github settings. |
856ae98
to
d3ecfe8
Compare
d3ecfe8
to
206c332
Compare
Updated the Cache and compare the test time between
Build time actually improved. (except |
206c332
to
c446c46
Compare
# This workflow uses actions that are not certified by GitHub. | ||
# They are provided by a third-party and are governed by | ||
# separate terms of service, privacy policy, and support | ||
# documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this sentence here? Depending on the reason, you might want the same sentence in .github/workflows/ci.yml
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not our script. We should leave it as is in so in the future we get a fresh new one instead of fixing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just a caveat emptor that you're using third-party code on GH Actions and if something breaks it's not GHs fault. No harm in keeping it or removing it either way, but might make it easier to track down the provenance.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not our script.
Let's add a link to the source. Also, what's the license of the source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idk, it's from the Github action item, and I just click on it and make minor modification.
I'm pretty sure it's open license, because there are plenty projects use this, although I don't have time to find the exact original license of this source.
move to seperate github action compact CI rename file fix name add clippy as well just check example shorten the test time
fc33a1d
to
d0d3ce0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDIT: Doesn't look ready to merge.
Close this PR due to no time to work on it anymore. Although the CI build is improved and Code scanning will be helpful to the project. |
No description provided.