Add Nova Public Parameter benchmark for SDK #267
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
.github/workflows/ci.yml
Outdated
| @@ -70,3 +70,29 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| steps: | |||
| - uses: bnjbvr/cargo-machete@main | |||
|
|
|||
| bench-riscv: | |||
There was a problem hiding this comment.
Benches for every small commit is too much, for example we don't run nova benchmarks as a workflow
There was a problem hiding this comment.
I run this part in my local and it's fast enough to run on CI. It takes 5 minutes CI, I think it's alright.
Because I want to have continuous benchmarking flow on CI.
I can add a label feature, whenever the benchmark label is added, the CI workflow benchmark will be executed.
duc-nx
force-pushed
the
pr267
branch
2 times, most recently
from
0c50e81 to
d4631bc
Compare
|
I had a hard time moving from |
|
You don't need to use the |
Summary: Test Plan:
| @@ -4,6 +4,7 @@ use ark_relations::r1cs::{ConstraintSystemRef, SynthesisError}; | |||
| use nexus_nova::StepCircuit; | |||
| use std::marker::PhantomData; | |||
|
|
|||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
This shouldn't be dead code.
There was a problem hiding this comment.
Since this is a shared code, it is used in other benches, however I don't use the NUM_WARMUP_STEPS in my code, so I turn off the clippy warning in compilation.
There was a problem hiding this comment.
True I guess it is dead for that individual build... I mean it's all test code so I guess that's fine...
There was a problem hiding this comment.
coincidently, the value of NUM_WARMUP_STEPS is 10, the minimum I need in criterion sample size is 10, I can plug in this value in my code and get rid of the allow[dead_code], but the variable name doesn't quite describe what the situation.
|
moved to |
| @@ -90,3 +90,13 @@ jobs: | |||
| run: | | |||
| cargo bench --bench riscv_machine | |||
|
|
|||
| bench-nova-public-params: | |||
There was a problem hiding this comment.
Why not also benchmark the provers themselves?
There was a problem hiding this comment.
Good question. I tried, criterion need 10 samples at least, one prover run on CI takes 4-6 minutes, which lead to at least 40 to 60 minutes to benchmark Prover.
I have plan to move all CI tasks, including benchmark prover to self-host Github Action in near future.
Summary:
Test Plan:
Stack created with Sapling. Best reviewed with ReviewStack.