Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to Shaka Error Handling #12

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

William-Paradis
Copy link

@William-Paradis William-Paradis commented Nov 13, 2024

📖 Description

This PR originates from the mirego/video-shaka-js fork, and we believe it could be a valuable addition to the official library.

This PR introduces a mapper to transform Shaka errors into a more organized format for New Relic.

👷 Work Done

  • Attached the error EventListener to the player instead of its tag. This change seemed necessary to obtain the detail of the error. It is also the method described in the Shaka documentation: https://shaka-player-demo.appspot.com/docs/api/tutorial-errors.html
  • Introduced a mapper to transform Shaka errors into a more organized format for New Relic, aiming to align as closely as possible with their Data dictionary.
    • Changed message to errorMessage
    • Changed code to errorCode
    • etc.
  • Added tests for the features introduced .

🗒 Notes

I've also noticed that the -p flag used by Webpack for building the library is no longer supported, so I've updated package.json to utilize the new --mode flag.

@CLAassistant
Copy link

CLAassistant commented Nov 13, 2024

CLA assistant check
All committers have signed the CLA.

@William-Paradis William-Paradis marked this pull request as draft November 13, 2024 02:20
@William-Paradis William-Paradis marked this pull request as ready for review November 13, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants