Enhancements to Shaka Error Handling #12
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description
This PR originates from the mirego/video-shaka-js fork, and we believe it could be a valuable addition to the official library.
This PR introduces a mapper to transform Shaka errors into a more organized format for New Relic.
👷 Work Done
EventListener
to the player instead of its tag. This change seemed necessary to obtain the detail of the error. It is also the method described in the Shaka documentation: https://shaka-player-demo.appspot.com/docs/api/tutorial-errors.htmlmessage
toerrorMessage
code
toerrorCode
🗒 Notes
I've also noticed that the
-p
flag used by Webpack for building the library is no longer supported, so I've updatedpackage.json
to utilize the new--mode
flag.