Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: #7 - Allow devices in Child Locations #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes: #7 - Allow devices in Child Locations #9

wants to merge 1 commit into from

Conversation

DanSheps
Copy link
Member

@DanSheps DanSheps commented Mar 7, 2024

Fixes: #7 - Allow devices in Child Locations

  • Alter queryset to allow devices in child locations to be added

@DanSheps
Copy link
Member Author

DanSheps commented Mar 7, 2024

@natm Can't assign reviewers for some reason. If you could give this a look see that would be great.

@dionrowney
Copy link

dionrowney commented Mar 14, 2024 •
edited
Loading

Can someone review and approve this so I can start testing this in my dev environment? Is this something I can do?

dionrowney
dionrowney approved these changes Mar 18, 2024
View reviewed changes
Copy link

@dionrowney dionrowney left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Tested this and it works as expected.

dionrowney
dionrowney suggested changes Mar 18, 2024
View reviewed changes
Copy link

@dionrowney dionrowney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I see all devices and racks rather than just racks in the current location and sub locations. It solves the problem but I was not expecting to see ALL objects.

dionrowney
dionrowney approved these changes Mar 18, 2024
View reviewed changes
Copy link

@dionrowney dionrowney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon closer investigation it seems to be a UI error that causes the list to display everything. I would say the initial list displayed is correct and I will submit a bug for this new error once this change is in the main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dionrowney dionrowney dionrowney approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow devices from child locations to be included in drawing
2 participants
@DanSheps @dionrowney