Fix Biome network codec not ignoring field redirects

[embeddedt]

This PR adds the corresponding biome info patch to Biome's network codec, not just the regular codec. Previously it seems some data was not being synced to the client correctly; this change fixes #1733.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: 81ac216ce6456cab6fa488d4e8d79a500352cca8.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged:neoforge:21.4.22-beta-pr-1766-fix-biome-music-fade-out
• 📦 net.neoforged:testframework:21.4.22-beta-pr-1766-fix-biome-music-fade-out

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1766' // https://github.com/neoforged/NeoForge/pull/1766
        url 'https://prmaven.neoforged.net/NeoForge/pr1766'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1766.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1766
cd NeoForge-pr1766
curl -L https://prmaven.neoforged.net/NeoForge/pr1766/net/neoforged/neoforge/21.4.22-beta-pr-1766-fix-biome-music-fade-out/mdk-pr1766.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[Technici4n]

Looks strange. Doesn't this essentially hide any biome effect modification from the client?

[embeddedt]

🤷‍♂️ I don't fully understand the purpose of the original codec patch to begin with; it just looked inconsistent to apply it to one codec and not the other. There might be another way of solving this problem. The symptom is that the background music volume for the pale garden biome is still 1.0 (rather than 0.0) without the patch.

[Technici4n]

I think we should understand why this fixes the problem before going for this potential solution.