-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add registry context to LootTableLoadEvent
#1677
base: 1.21.x
Are you sure you want to change the base?
Conversation
Last commit published: 828b516b85d88540c4bcd1a0394a114786b3cba9. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1677' // https://github.com/neoforged/NeoForge/pull/1677
url 'https://prmaven.neoforged.net/NeoForge/pr1677'
content {
includeModule('net.neoforged', 'testframework')
includeModule('net.neoforged', 'neoforge')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1677
cd NeoForge-pr1677
curl -L https://prmaven.neoforged.net/NeoForge/pr1677/net/neoforged/neoforge/21.4.14-beta-pr-1677-gh-1625/mdk-pr1677.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
@Matyrobbrt, this PR introduces breaking changes.
|
if (table == LootTable.EMPTY) // Empty table has a null name, and shouldn't be modified anyway. | ||
return null; | ||
LootTableLoadEvent event = new LootTableLoadEvent(name, table); | ||
LootTableLoadEvent event = new LootTableLoadEvent(registries, name, table); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did it end up that you added the lookup provider to the end of the args for loadLootTable
but the front of the args for LoadLootTableEvent
?
Closes #1625
Adds an AT for
RegistryOps.lookupProvider
to be able to extract it from method that only have a registry ops.