-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.21.4] Add event fired at the start of the framegraph setup #1598
base: 1.21.x
Are you sure you want to change the base?
Conversation
Last commit published: 1c4037e31271110b156b73fdec4c5e507896b42e. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1598' // https://github.com/neoforged/NeoForge/pull/1598
url 'https://prmaven.neoforged.net/NeoForge/pr1598'
content {
includeModule('net.neoforged', 'testframework')
includeModule('net.neoforged', 'neoforge')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1598
cd NeoForge-pr1598
curl -L https://prmaven.neoforged.net/NeoForge/pr1598/net/neoforged/neoforge/21.4.22-beta-pr-1598-frame_graph_setup_events/mdk-pr1598.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
69ed39b
to
e18c200
Compare
@XFactHD, this pull request has conflicts, please resolve them for this PR to move forward. |
4b13bc4
to
1734745
Compare
@XFactHD, this pull request has conflicts, please resolve them for this PR to move forward. |
I've flattened the two events into a single one and moved it slightly earlier to fire it between vanilla setting up "global" resources and adding the frame passes. The event can primarily be used to set up custom resources such as |
@XFactHD, this pull request has conflicts, please resolve them for this PR to move forward. |
…s and enabling entity outline post-processing
8a902da
to
1c4037e
Compare
This PR adds events during the framegraph setup at the start of level rendering. These allow adding custom passes to the graph and enabling entity outline post-processing without any entities in view having active outlines.
The pre event is fired right after the "clear" pass is set up and the post event is fired right before the graph is executed.
Opening as a draft for now because I'm not totally sure whether the split into pre and post is actually useful or whether the pre event primarily for the outline stuff and people using mixins to precisely inject custom passes between vanilla passes is more suitable.