Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CHECK_URL in kuberhealthy checks to respect namespaces #2779

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ spec:
image: kuberhealthy/http-check:v1.5.0
imagePullPolicy: IfNotPresent
env:
- name: CHECK_URL
value: "http://nebari-conda-store-server.dev:5000"
- name: COUNT #### default: "0"
value: "5"
- name: SECONDS #### default: "0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ spec:
image: kuberhealthy/http-check:v1.5.0
imagePullPolicy: IfNotPresent
env:
- name: CHECK_URL
value: "http://hub.dev:8081"
- name: COUNT #### default: "0"
value: "5"
- name: SECONDS #### default: "0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@ spec:
image: kuberhealthy/http-check:v1.5.0
imagePullPolicy: IfNotPresent
env:
- name: CHECK_URL
value: "http://keycloak-http.dev"
- name: COUNT #### default: "0"
value: "5"
- name: SECONDS #### default: "0"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,31 @@ patches:
- op: replace
path: /metadata/namespace
value: "{{ namespace }}"
- target:
kind: KuberhealthyCheck
name: conda-store-http-check
patch: |-
- op: add
path: /spec/podSpec/containers/0/env/-
value:
name: CHECK_URL
value: "http://nebari-conda-store-server.{{ namespace }}:5000"
- target:
kind: KuberhealthyCheck
name: jupyterhub-http-check
patch: |-
- op: add
path: /spec/podSpec/containers/0/env/-
value:
name: CHECK_URL
value: "http://
hub.{{ namespace }}:8081"
- target:
kind: KuberhealthyCheck
name: keycloak-http-check
patch: |-
- op: add
path: /spec/podSpec/containers/0/env/-
value:
name: CHECK_URL
value: "http://keycloak-http.{{ namespace }}"
Loading