Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Allow auto-completed values to be recognized. Resolves #94 #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EpicVoyage
Copy link

@EpicVoyage EpicVoyage commented Oct 29, 2021

I manually tested this change with npm start and Chrome browser autofill (#94).

I have also generated a build via npm run build:dist for inclusion in my project. This seems to be working well so far.

Copy link
Contributor

@ArtemDintecom ArtemDintecom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EpicVoyage It would be nice to do this and test with the latest changes in master

@cmcnulty
Copy link

cmcnulty commented Nov 7, 2023

I believe that the problem is not that we need to add a change listener. When a pre-filled value is selected, the only event fired is "input" - however on any browser other than android-chrome, the handle input function is not fired. The issue can be fixed on at least macos simply by removing the test for android-chrome.

On a larger scale, I wonder why that check is there (unchanged for many years) and whether it is still necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants