Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC, feat: infer datetime format for pyarrow backend #1195

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

FBruzzesi
Copy link
Member

@FBruzzesi FBruzzesi commented Oct 16, 2024

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

As discussed in the comment of the PR tagged in the issue, the implementation is inspired by and adjusted from the following repository: datetime-format.

I am opening this as draft and looking for help for:

  • Enlarge the test suite with multiple formats, if it would be possible to do this dynamically (maybe with hypothesis it would be great - I never used it though)
  • Add other common formats:
    • allow for AM/PM
    • Are there other date separators?
    • Are there other time separators?
    • other?

For the two latter questions, sometimes at work we use no separators e.g. YYYYmmddHHMMSS

PS: CI Failure on doctest is unrelated

@FBruzzesi FBruzzesi added enhancement New feature or request high priority labels Oct 16, 2024
@MarcoGorelli
Copy link
Member

ooh, nice!

I think this might already be a good start? if we can at least auto-detect iso8601-like formats, that's already an improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enh]: Infer datetime format for pyarrow backend in to_datetime(format=None) case
2 participants