-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make template more flexible with tuneable attributes #4
base: master
Are you sure you want to change the base?
Conversation
Learned something new: Go figure. EDIT: oops. ruby of rails. no go. |
cc: @anusch-athari As in the openssh cookbook, there are some commented out lines in the original template that should go into commented out lines in the cookbook attributes file. Thoughts? |
…to generate properly.
Hi @patcon I don't really think it makes a big difference which way of generating the config file we use. I would say the main problem here is, if wegrind chooses to change it's configuration file this might break the cookbook. |
Yeah, even as I was writing it, it didn't seem right for a php config file. Might consider talking to webgrind folks and see if they'd consider switching to an ini format. That way, could have the config file, complete with comment, and just add something to the bottom of the template that would allow configs to be written -- since overwriting a previously declared ini directive isn't an issue, it would be cleaner. |
Yep my thoughts exactly. |
Yeah, it looked the same to me -- and the issue queue is piling up a bit. Tweeted a msg to the maintainer about bringing some others on the help, so I'll keep you posted if I hear back :) |
Great, hope he answers. But stuff like this is one of my biggest problems right now. I really don't know how to handle the fragmentation and dead projects on github. How do you handle this kind of stuff? |
Ah yeah, the jenkins cookbook is particularly confusing. I've spoken with the maintainer, and he's a little frustrated with the landscape as well. From his point of view, there are just so many different ways that people might want to deploy and manage jenkins, that it seems impossible to maintain a cookbook that suits everyone. To explain though, fnichol was the original maintainer and owner of the community site namespace, and then AJ at heavywater took it over because he'd been working on it heavily while creating a project called pennyworth that got some attention. But yeah, the jenkins cookbook has been a bit neglected lately, and he's aware of that. While it might not be the best approach for the jenkins cookbook, I usually try to kick off a thread summarizing all the diverse efforts, and @-mentioning all the maintainers into a single issue to hash out whether they'd be interested in focusing efforts. Kinda like this (even though it didn't work out in this case): |
Thanks for the endorsement. I will try your approach for the jenkins cookbook. Who knows. |
👍 |
As suggested in #2, perhaps we could make the template a little more flexible as the
php
andopenssh
cookbooks have done:https://github.com/opscode-cookbooks/php/blob/master/templates/default/php.ini.erb#L1898-L1900
https://github.com/opscode-cookbooks/openssh/blob/master/templates/default/ssh_config.erb#L3-L11
The second link in particular is useful to look at as it shows how camelcase can be derived from underscored values.
Will submit a PR later