[PageContainer] Allow full-size content #4480
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apedroferreira
added
core
apedroferreira
commented
Nov 26, 2024
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "props": {}, | |||
| "props": { "children": { "type": { "name": "node" } } }, | |||
There was a problem hiding this comment.
Proptypes are now being generated for the components which don't match the name of the folder (secondary components), I think that should be a good thing?
Changed it in the script that generates proptypes so that the API documentation for PageHeader would be there, auto-generated.
apedroferreira
commented
Nov 26, 2024
| @@ -204,7 +204,7 @@ async function run(argv: HandlerArgv) { | |||
| folderName = folderName.slice(9); | |||
| } | |||
|
|
|||
| return fileName === folderName; | |||
| return !fileName.endsWith('.test'); | |||
There was a problem hiding this comment.
Generates proptypes for all non-test files inside the folder of each component.
apedroferreira
changed the title
apedroferreira
added
scope: toolpad-core
|
Looks like the CI is having out of memory issues again, we probably either need to manage dependencies to stay under or increase instance sizes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4324
Needed it already in the CRUD for the list table to take up the full space in the layout.
As per the discussion in #4324:
PageContainerwithflex: 1orheight: 100%.sxprop toPageContainer.PageHeaderfromPageContainerto optionally be used as a standalone componenthttps://deploy-preview-4480--mui-toolpad-docs.netlify.app/toolpad/core/react-page-container