[pickers] Add new method onToggleOpening to usePickerContext()
#15701
+29
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
the
component: pickers
flaviendelangle
commented
Dec 2, 2024
| @@ -67,6 +68,14 @@ export function usePickerProvider<TValue extends PickerValidValue>( | |||
| const utils = useUtils(); | |||
| const orientation = usePickerOrientation(views, props.orientation); | |||
|
|
|||
| const handleTogglePicker = useEventCallback((event: React.UIEvent) => { | |||
There was a problem hiding this comment.
It could be an action exposed by usePickerValue but it has more implications (all actions are forwarded to PickersPopper for now.
Until the actions are always accessed through the state, I propose to keep it here to avoid problems.
flaviendelangle
changed the title
onToggleOpening to the picker public contextonToggleOpening to usePickerContext()
|
Deploy preview: https://deploy-preview-15701--material-ui-x.netlify.app/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #15671, I started to duplicate a lot the
handleTogglePickermethod.WDYT about exposing both
onOpen/onClose/openAND theonToggleOpeningmethod.It cleans our doc demos a bit to focus on the interesting part and I guess most people would prefer to use the shortcut anyway.