Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGridPro] Cleanup pinned rows on removal #15697

Merged
merged 2 commits into from
Dec 2, 2024
Merged

[DataGridPro] Cleanup pinned rows on removal #15697

merged 2 commits into from
Dec 2, 2024
+21 −1

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Dec 2, 2024 •
edited
Loading

@cherniavskii cherniavskii added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! plan: Pro Impact at least one Pro user feature: Row pinning Related to the data grid Row pinning feature labels Dec 2, 2024
@mui-bot
Copy link

mui-bot commented Dec 2, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-15697--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against cd4188f

@cherniavskii cherniavskii added needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Dec 2, 2024
@cherniavskii cherniavskii marked this pull request as ready for review December 2, 2024 13:44
@cherniavskii cherniavskii requested a review from a team December 2, 2024 14:21
romgrk
romgrk approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@romgrk romgrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will conflict with #15698

@cherniavskii cherniavskii merged commit 65ca208 into mui:master Dec 2, 2024
22 checks passed
@cherniavskii cherniavskii deleted the pinnedRows-cleanup branch December 2, 2024 16:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Cherry-pick PRs will be created targeting branches: v7.x

github-actions bot pushed a commit that referenced this pull request Dec 2, 2024
@cherniavskii @web-flow
[DataGridPro] Cleanup pinned rows on removal (#15697)
ece2dfd
@github-actions github-actions bot mentioned this pull request Dec 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romgrk romgrk romgrk approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Row pinning Related to the data grid Row pinning feature needs cherry-pick The PR should be cherry-picked to master after merge plan: Pro Impact at least one Pro user v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[data grid] Pinned rows are hidden after unpinning
3 participants
@cherniavskii @mui-bot @romgrk