Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bugs): Send low recovery codes email when consuming during password reset #17859

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(bugs): Send low recovery codes email when consuming during password reset #17859

wants to merge 1 commit into from

Conversation

vbudhram
Copy link
Contributor

Because

  • We don't want a user to get locked out of account if they run out of recovery codes

This pull request

  • Emails the user to let them know a code was consumed (and how many remaining), also emails user if they have "low" amount

Issue that this pull request solves

Closes: https://mozilla-hub.atlassian.net/browse/FXA-10555

Checklist

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

@vbudhram vbudhram self-assigned this Oct 18, 2024
@vbudhram vbudhram requested a review from a team as a code owner October 18, 2024 19:23
chenba
chenba reviewed Oct 18, 2024
View reviewed changes
packages/fxa-auth-server/lib/routes/totp.js
);
}

await Promise.all(mailerPromises);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Promise.allSettled is more appropriate here.

chenba
chenba approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@chenba chenba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenba chenba chenba approved these changes

Assignees

@vbudhram vbudhram

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbudhram @chenba