-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task(auth): Use nest di #17412
Draft
dschom
wants to merge
2
commits into
main
Choose a base branch
from
hapi-nest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
task(auth): Use nest di #17412
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
/* This Source Code Form is subject to the terms of the Mozilla Public | ||
* License, v. 2.0. If a copy of the MPL was not distributed with this | ||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
||
import { Module } from '@nestjs/common'; | ||
import { NestFactory } from '@nestjs/core'; | ||
import { ConfigModule } from '@nestjs/config'; | ||
import { Container } from 'typedi'; | ||
import { MozLoggerService } from '@fxa/shared/mozlog'; | ||
import { | ||
LegacyStatsDProvider, | ||
StatsD, | ||
StatsDService, | ||
} from '@fxa/shared/metrics/statsd'; | ||
import { NotifierService, NotifierSnsFactory } from '@fxa/shared/notifier'; | ||
|
||
import config, { ConfigType } from '../config'; | ||
import { AppConfig } from './types'; | ||
|
||
@Module({ | ||
imports: [ | ||
ConfigModule.forRoot({ | ||
load: [(): ConfigType => config.getProperties()], | ||
isGlobal: true, | ||
}), | ||
], | ||
controllers: [], | ||
providers: [ | ||
MozLoggerService, | ||
NotifierSnsFactory, | ||
NotifierService, | ||
LegacyStatsDProvider, | ||
], | ||
}) | ||
export class AppModule {} | ||
|
||
export async function getAppModuleInstance() { | ||
return await NestFactory.createApplicationContext(AppModule); | ||
} | ||
|
||
export async function bridgeTypeDi() { | ||
const appInstance = await getAppModuleInstance(); | ||
|
||
// Setup type di container for backwards compatibility | ||
Container.set(AppConfig, config.getProperties()); | ||
Container.set(StatsD, appInstance.get(StatsDService)); | ||
Container.set(MozLoggerService, appInstance.resolve(MozLoggerService)); | ||
Container.set(NotifierService, appInstance.get(NotifierService)); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
@Inject(...)
going to be necessary for everything consumed by Auth? We haven't had to do that over on the Subplat side so far as long as something is marked as@Injectable
, is that still the case?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I got an error without it which is a little strange, because as you point out it doesn't seem to have been necessary in other projects. I wonder if there's a better solution. I can try removing it, and see if I can get it working without adding injects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is apparently because
esbuild
does not properly support emitting metadata, so the decorators are only spotted and the information available in some parts:evanw/esbuild#257
Switching to swc to run this should remedy it. Sigh.