Skip to content

Commit

Permalink
Merge pull request #16929 from mozilla/FXA-9323
Browse files Browse the repository at this point in the history
fix(functional-test): update failing cookies disabled test
  • Loading branch information
sardesam authored May 13, 2024
2 parents fcea00b + 3da691a commit 88114a3
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions packages/functional-tests/tests/misc/cookiesDisabled.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,8 @@ test.describe('cookies disabled', () => {
test('visit verify page with localStorage disabled', async ({
target,
page,
pages: { cookiesDisabled, login },
pages: { cookiesDisabled },
}) => {
test.fixme(true, 'Fix required as of 2024/03/22 (see FXA-9323).');
//Goto cookies enabled url
await page.goto(
`${target.contentServerUrl}/verify_email?disable_local_storage=1&uid=240103bbecd645848103021e7d245bcb&code=fc46f44802b2a2ce979f39b2187aa1c0`,
Expand All @@ -81,10 +80,11 @@ test.describe('cookies disabled', () => {
);
await page.waitForURL(/\/cookies_disabled/);

//Adding the timeout as the page closes before loading
await page.waitForTimeout(500);

//Verify the Cookies disabled header
await expect(await cookiesDisabled.cookiesDisabledHeader()).toBeVisible();
// Verify the Cookies disabled header
// Updated in FXA-9323 as waitForTimeOut tests can be flaky in production:
// https://playwright.dev/docs/api/class-page#page-wait-for-timeout
await expect(cookiesDisabled.cookiesDisabledHeader()).resolves.toBeVisible({
timeout: 500,
});
});
});

0 comments on commit 88114a3

Please sign in to comment.