terms_stats facet type support #254
Conversation
|
0.10 was released already, so this won't make it into that version. But possibly 0.11 or 0.10.1 depending on how the future goes. This looks ok other than a bunch of pep8-related problems which makes it hard to read in github diff. Can you run pep8 or flake8 on this and fix the resulting issues? Then I'll go through it more closely. |
| cls.get_es().indices.put_mapping( | ||
| index=cls.index_name, doc_type=cls.mapping_type_name, body=mapping) | ||
|
|
||
| @classmethod |
There was a problem hiding this comment.
I don't think we need put_mapping unless we're incrementally building the index. If you look at other tests, they just wipe the index and add a new mapping or they set the mapping in the class attributes. Either one is better since it exists already.
|
I'm definitely going to do an ElasticUtils 0.10.1 release. I'm happy to wait for this PR to resolve itself so it can get in. Can you work through the comments in the next couple of days? If not, I can take your PR and fix it up. |
|
Also, thank you for doing this! |
|
Thanks for looking at this, I'll try to look at this in the next day or so. |
|
Awesome--thank you! |
adds terms stats support.
I think it's failing because travis pulling down the wrong version of ES and my code is still based on .9. I can update it if need be. Tests are passing locally for me though.
Much <3 if this can be into .10.