Bug 1508201 - Allow bulk edits to happen in the background, asynchronously #973
Conversation
|
diff --git a/t/bulk-edit.t b/t/bulk-edit.t index b6aebec10..a97fa7f98 100644 --- a/t/bulk-edit.t +++ b/t/bulk-edit.t @@ -1,4 +1,4 @@ -#!/usr/bin/perl +#!/usr/bin/env perl # This Source Code Form is subject to the terms of the Mozilla Public # License, v. 2.0. If a copy of the MPL was not distributed with this # file, You can obtain one at http://mozilla.org/MPL/2.0/. |
There was a problem hiding this comment.
- Install code needs to create the bulk_edit group during checksetup
- IMO the group should be called can-bulk-edit but not fussed either way.
- process_bug.cgi does not check that user is in group bulk_edit that I can tell and allows anyone to bulk edit. But the template does check. Which policy do we want?
It did, but it was probably hard to see. Now it's |
dylanwh
force-pushed
the
bg-bulk-edits
branch
from
fa97467
to
66a2199
Compare
|
|
||
| # Make sure there are bugs to process. | ||
| ThrowUserError("no_bugs_chosen", {action => 'modify'}) unless @bug_ids; | ||
| $async_bulk_edit = 1 if @bug_ids > 10; |
There was a problem hiding this comment.
Just noticed this. Seems that even if the user does not check the bulk edit checkbox on buglist.cgi, it will still enable it if @bug_ids > 10 which negates the need for a checkbox altogether.
Maybe this should be instead:
$async_bulk_edit = 0 if @bug_ids < 10;
Or am I missing something?
There was a problem hiding this comment.
right now, doing > 10 edits is likely to fail, so it's meant to make them more likely to succeed. Eventually bz_async_bulk_edit should be the same as editbugs. Does that make sense?
There was a problem hiding this comment.
Sounds fine. But is still sort of misleading from a user standpoint. Maybe we should add some text or tooltip that states it is automatic if more than 10 bugs?
Updated with (I think) all review changes applied.