This repository has been archived by the owner on Oct 4, 2021. It is now read-only.
Fixed 'Bug 576819: Extract Interface... OK button is disabled when #4070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dialog is initially shown (works in VS2017)' https://devdiv.visualstudio.com/DevDiv/_workitems/edit/576819 Found & fixed an issue with the cell view update as well.
|
See : |
|
cc @sevoku |
Therzok
reviewed
Mar 7, 2018
| @@ -108,7 +108,12 @@ public ExtractInterfaceDialog () | |||
| listViewPublicMembers.DataSource = treeStore; | |||
| var checkBoxCellView = new CheckBoxCellView (symbolIncludedField); | |||
| checkBoxCellView.Editable = true; | |||
| checkBoxCellView.Toggled += delegate { UpdateOkButton ();}; | |||
| checkBoxCellView.Toggled += delegate { | |||
| GLib.Timeout.Add (20, delegate { | |||
There was a problem hiding this comment.
Can we track this hack in a github issue so we don't forget?
There was a problem hiding this comment.
It's here : mono/xwt#795
There was a problem hiding this comment.
Created a issue tracking this on our side #4075.
Easier than an issue in xwt with cross references, so we don't lose track of it.
There was a problem hiding this comment.
Not a big thing to track if you ask me - we've some time outs for similiar behaviors. It's not that this code won't run in ~10 years :) - it's even likely that it will because no one cares about working code and refactoring :/
Therzok
approved these changes
Mar 7, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dialog is initially shown (works in VS2017)'
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/576819
Found & fixed an issue with the cell view update as well.